Make WordPress Core

#62914 closed defect (bug) (reported-upstream)

Social Icons having top and bottom margin issue in the editor with classic themes

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.9
Component: Editor Keywords:
Focuses: css Cc:

Description

Hello Team,

I have checked "Social Icons" block and found that the icons contains extra "top" & "bottom" margin space into the editor side.

But, front-end it looks good. So, I think that it should be same on both(Front-end & Back-end)sides.

For better understanding, here I have attached its screenshots.

Thanks,

Attachments (5)

twenty-nineteen-social-icons.png (109.7 KB) - added by viralsampat 10 months ago.
Back-end
twenty-nineteen-social-icons-front-end.png (100.0 KB) - added by viralsampat 10 months ago.
Front-end
62914.patch (476 bytes) - added by viralsampat 10 months ago.
I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.
after-resolve-twenty-nineteen-social-icons.png (102.2 KB) - added by viralsampat 10 months ago.
After resolved issue Back-end:
after-resolve-twenty-nineteen-social-icons-front-end.png (99.2 KB) - added by viralsampat 10 months ago.
After resolved issue front-end:

Download all attachments as: .zip

Change History (10)

@viralsampat
10 months ago

I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.

@viralsampat
10 months ago

After resolved issue Back-end:

@viralsampat
10 months ago

After resolved issue front-end:

#1 @sainathpoojary
10 months ago

Hey @viralsampat,

I wasn’t able to reproduce the mentioned issue in both WordPress trunk and 6.7.2-RC1. However, I was able to reproduce the issue when running Gutenberg on the trunk version.

Can you please confirm if you’re seeing the same behavior on your end?

#2 @viralsampat
10 months ago

Hello @sainathpoojary

Thank you so much for you feedback.

I will check using latest trunk and will update asap.

Thanks,

#3 @sabernhardt
10 months ago

  • Component changed from Bundled Theme to Editor
  • Keywords move-to-github close added; needs-patch dev-feedback needs-testing removed
  • Summary changed from Twenty Nineteen Theme: Social Icons having top and bottom margin issue into the editor side. to Social Icons having top and bottom margin issue in the editor with classic themes
  • Version set to trunk

Please open a Gutenberg issue. This needs to be fixed in the plugin, not themes. It happens in the bundled themes from Twenty Ten to Twenty Twenty, plus other classic themes. The icon has a .wp-block class in the editor now (since GB64883?), and classic.scss adds top and bottom margins for those elements.

#4 @sabernhardt
10 months ago

  • Keywords move-to-github close removed
  • Milestone Awaiting Review deleted

#5 @sabernhardt
10 months ago

  • Resolution set to reported-upstream
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.