Twenty Twenty: aria-controls & aria-expanded attributes missing from primary menu

[bschneidewind]

On the TwentyTwenty theme, dropdown menus on the primary menu are missing the aria-controls and aria-expanded attributes.

On the TwentyTwenty theme, dropdown menus on the primary menu are missing the aria-controls and aria-expanded attributes.

Trac ticket: https://core.trac.wordpress.org/ticket/62916

I can confirm the PR addresses the issue.

## Before patch

## After patch

[shailu25]

Test Report

Patch Tested: ​https://github.com/WordPress/wordpress-develop/pull/8272

Environment:
WordPress - 6.8-alpha-20250207.133319
OS - Windows
Browser - Firefox
Theme: Twenty Twenty
PHP - 8.2.12
Active Plugin: None

Actual Results:

• Issue Resolved With Patch.✅

Screenshots:

• Added Attachment

[shailu25]

Before Patch

[shailu25]

After Patch

[joedolson]

It's debatable whether these should actually have aria-expanded attributes. There is no action taken to open or close these menus. From a screen-reader perspective, they aren't actually hidden, and there's no need to disclose them - the navigation is continuous.

aria-expanded is intended to convey the results of an action with a state change; but there's no state change here. The sub menus are only hidden visually, using off-screen positioning similar to screen reader text classes.

In my opinion, not having aria-expanded is correct here, given the behavior.

@afercia Your opinion?

[joedolson]

Following discussion in the March 4, 2025 accessibility bug scrub, we're closing this, as it's not actually an improvement per the previous comment.

[afercia]

@joedolson I'd agree that aria-expanded isn't necessary because the menu items don't require activation to show the sub-menus. Instead, the responsive menu provides a separate button to open tue sub-menus and it does use aria-expanded.