![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#62916 closed defect (bug) (invalid)
Twenty Twenty: aria-controls & aria-expanded attributes missing from primary menu
| Reported by: | bschneidewind | Owned by: | joedolson |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Bundled Theme | Version: | 5.3 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | accessibility |
Description
On the TwentyTwenty theme, dropdown menus on the primary menu are missing the aria-controls and aria-expanded attributes.
Attachments (2)
Change History (12)
This ticket was mentioned in PR #8272 on WordPress/wordpress-develop by @bschneidewind.
17 months ago
#1
- Keywords has-patch added
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
17 months ago
@audrasjb commented on PR #8272:
17 months ago
#4
I can confirm the PR addresses the issue.
## Before patch
## After patch
#5
@
17 months ago
Test Report
Patch Tested: https://github.com/WordPress/wordpress-develop/pull/8272
Environment:
WordPress - 6.8-alpha-20250207.133319
OS - Windows
Browser - Firefox
Theme: Twenty Twenty
PHP - 8.2.12
Active Plugin: None
Actual Results:
- Issue Resolved With Patch.✅
Screenshots:
- Added Attachment
#6
@
17 months ago
It's debatable whether these should actually have aria-expanded attributes. There is no action taken to open or close these menus. From a screen-reader perspective, they aren't actually hidden, and there's no need to disclose them - the navigation is continuous.
aria-expanded is intended to convey the results of an action with a state change; but there's no state change here. The sub menus are only hidden visually, using off-screen positioning similar to screen reader text classes.
In my opinion, not having aria-expanded is correct here, given the behavior.
@afercia Your opinion?
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
16 months ago
#8
@
16 months ago
- Milestone 6.8
- Resolution → invalid
- Status accepted → closed
Following discussion in the March 4, 2025 accessibility bug scrub, we're closing this, as it's not actually an improvement per the previous comment.
#9
@
16 months ago
@joedolson I'd agree that aria-expanded isn't necessary because the menu items don't require activation to show the sub-menus. Instead, the responsive menu provides a separate button to open tue sub-menus and it does use aria-expanded.
@joedolson commented on PR #8272:
4 months ago
#10
Related ticket was closed because this change is not necessary; closing PR.
On the TwentyTwenty theme, dropdown menus on the primary menu are missing the aria-controls and aria-expanded attributes.
Trac ticket: https://core.trac.wordpress.org/ticket/62916