Opened 14 hours ago
Last modified 4 hours ago
#63013 new enhancement
Twenty Nineteen: Use `sass` instead of `node-sass`
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Awaiting Review | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Bundled Theme | Keywords: | has-patch |
| Focuses: | javascript, css | Cc: |
Description
node-sass is deprecated and no longer maintained. We should switch to sass, the official and actively supported Sass compiler, to stay up-to-date with the latest features and improvements.
Change History (3)
This ticket was mentioned in PR #8404 on WordPress/wordpress-develop by @debarghyabanerjee.
14 hours ago
#1
- Keywords has-patch added; needs-patch removed
This ticket was mentioned in PR #8405 on WordPress/wordpress-develop by @debarghyabanerjee.
13 hours ago
#2
Trac Ticket: Core-63013
### Summary
This PR replaces node-sass with sass in the twentynineteen theme. node-sass is deprecated and no longer maintained, while sass is the official, actively supported implementation of Sass.
#3
@
4 hours ago
- Component changed from Themes to Bundled Theme
- Summary changed from Update: Use `sass` instead of `node-sass` in twentynineteen theme to Twenty Nineteen: Use `sass` instead of `node-sass`
@sainathpoojary also reported the deprecation on GitHub.
If the package switches to sass:
- The output is very different, especially with the order of language-specific selectors. Setting up some linting rules could help (for example, with
stylelint-config). - Please use
--no-source-map. Twenty Nineteen does not have the.mapfiles yet, and committing one change with the source maps could require refreshing any other pull requests that were made with older map files.
Note: See
TracTickets for help on using
tickets.
Trac Ticket: Core-63013
### Summary
This PR replaces
node-sasswithsassin the twentynineteen theme.node-sassis deprecated and no longer maintained, whilesassis the official, actively supported implementation of Sass.