WordPress.org
Get WordPress

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#63081 closed defect (bug) (fixed)

Account for `Core-{n}` format in the PR cleanup workflow

Reported by: johnbillion's profile johnbillion Owned by: desrosj's profile desrosj
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: good-first-bug has-patch commit
Focuses: Cc:

Description

The ​pull request cleanup workflow expects that a PR contains a ticket reference in the format https://core.trac.wordpress.org/ticket/{n}, but it's also possible to use the shorter format Core-{n}. PRs that use this format don't get cleaned up.

​Example PR here.

Ideally the workflow would be adjusted to handle either format.

Change History (4)

This ticket was mentioned in ​PR #8485 on ​WordPress/wordpress-develop by ​@yogeshbhutkar.
3 months ago #1

  • Keywords has-patch added; needs-patch removed

### Description

Trac ticket: Core-63081

This PR enhances the search query by enabling support for Core-{n}, improving the filtering of PRs.

​@yogeshbhutkar commented on ​PR #8485:
3 months ago #2

Hi, @desrosj. I believe you've worked with similar GitHub Actions before. If possible, can you please review this PR when you get a moment?

#3 @desrosj
3 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.9

#4 @desrosj
3 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 60110:

Build/Test Tools: Account for Core-{n} ticket references.

This expands the pull request cleanup action to also account for the Core-{n} pattern. This pattern dynamically links to Trac tickets without having to explicitly provide the ticket URL and are not detected in the current workflow logic.

Props yogeshbhutkar, johnbillion.
Fixes #63081.

Note: See TracTickets for help on using tickets.