Make WordPress Core

Opened 19 months ago

Last modified 19 months ago

#63137 reviewing defect (bug)

Getting Use isset() or empty() to check the index exists before using it error into the WordPress core files.

Reported by: viralsampat Owned by: audrasjb
Priority: normal Milestone: Awaiting Review
Component: General Version:
Severity: normal Keywords: changes-requested has-patch
Cc: Focuses: coding-standards

Description

Hello Team,

I have checked wp-admin WordPress core files and I have found this "Use isset() or empty() to check the index exists before using it" error for few files.

Here, I have listed files:

src/wp-admin/network/site-new.php
src/wp-admin/network/site-settings.php
src/wp-admin/network/site-users.php
src/wp-admin/network/sites.php
src/wp-admin/network/themes.php
src/wp-admin/network/user-new.php
src/wp-admin/network/users.php

I have tested this into the WordPress 6.8-beta1.

Thanks,

Attachments (6)

63137.patch​ (7.4 KB ) - added by viralsampat 19 months ago.
I have checked above mentioned issue and resolved it. Here, I have added my patch.
63137.2.patch​ (3.7 KB ) - added by viralsampat 19 months ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.
63137.3.patch​ (6.1 KB ) - added by viralsampat 18 months ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.
63137.4.patch​ (4.9 KB ) - added by viralsampat 17 months ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.
63137.5.patch​ (1.8 KB ) - added by viralsampat 17 months ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.
63137.6.patch​ (4.3 KB ) - added by viralsampat 16 months ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.

Download all attachments as: .zip

Change History (7)

@viralsampat
19 months ago

I have checked above mentioned issue and resolved it. Here, I have added my patch.

#1 @audrasjb
19 months ago

  • Keywords changes-requested has-patch added
  • Owner set to audrasjb
  • Status new → reviewing
  • Version trunk

Hello thanks for the ticket and patch,

Please note that inline comments like these are not necessary:

// Check post blog isset and not empty.

@viralsampat
19 months ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

@viralsampat
18 months ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

@viralsampat
17 months ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

@viralsampat
17 months ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

@viralsampat
16 months ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

Note: See TracTickets for help on using tickets.