Make WordPress Core

Opened 4 weeks ago

Last modified 4 weeks ago

#63137 reviewing defect (bug)

Getting Use isset() or empty() to check the index exists before using it error into the WordPress core files.

Reported by: viralsampat's profile viralsampat Owned by: audrasjb's profile audrasjb
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: General Keywords: changes-requested has-patch
Focuses: coding-standards Cc:

Description

Hello Team,

I have checked wp-admin WordPress core files and I have found this "Use isset() or empty() to check the index exists before using it" error for few files.

Here, I have listed files:

src/wp-admin/network/site-new.php
src/wp-admin/network/site-settings.php
src/wp-admin/network/site-users.php
src/wp-admin/network/sites.php
src/wp-admin/network/themes.php
src/wp-admin/network/user-new.php
src/wp-admin/network/users.php

I have tested this into the WordPress 6.8-beta1.

Thanks,

Attachments (3)

63137.patch (7.4 KB) - added by viralsampat 4 weeks ago.
I have checked above mentioned issue and resolved it. Here, I have added my patch.
63137.2.patch (3.7 KB) - added by viralsampat 3 weeks ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.
63137.3.patch (6.1 KB) - added by viralsampat 9 days ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.

Download all attachments as: .zip

Change History (4)

@viralsampat
4 weeks ago

I have checked above mentioned issue and resolved it. Here, I have added my patch.

#1 @audrasjb
4 weeks ago

  • Keywords changes-requested has-patch added
  • Owner set to audrasjb
  • Status changed from new to reviewing
  • Version trunk deleted

Hello thanks for the ticket and patch,

Please note that inline comments like these are not necessary:

// Check post blog isset and not empty.

@viralsampat
3 weeks ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

@viralsampat
9 days ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

Note: See TracTickets for help on using tickets.