Enhanced verification of $_REQUEST['reauth'] in the authentication process.

[wplmillet]

The $_REQUEST['reauth'] check currently uses a more up-to-date syntax:

<?php
$reauth = empty( $_REQUEST['reauth'] ) ? false : true;

This syntax could be updated to improve the code's readability and robustness. Two options are possible:

Use empty() :

<?php
$reauth = !empty($_REQUEST['reauth']);

Use coalescent Null operator :

<?php
$reauth = $_REQUEST['reauth'] ?? false;

Advantages :

• Better readability.
• Reduces redundant code.
• Modern PHP practices.

I'll be using more of the first solution with empty() seems to be better. It avoids the undesirable behavior associated with falsy values (0,'', ).

Impact:
No negative impact expected. No change in behavior and better code readability. and maintenance.

Thank you 🙂

[audrasjb]

Hello and thanks for the ticket @wplmillet,

Switching this to a bugfix and milestoning to 6.8.

Please note that the patch doesn't pass WordPress Coding Standards tests because we'll need spaces after and before opening and closing parenthesis, and also between ! and empty() :)

[wplmillet]

Fix and OK with WPCS

[audrasjb]

We are a couple hour before 6.8 RC1, moving to 6.9 as this is low priority.

[wildworks]

This ticket was brought up in today's 6.9 bug scrub. The patch seems ready to be committed, but what do you think, @audrasjb?

[SergeyBiryukov]

In 61085:

Coding Standards: Simplify the $_REQUEST['reauth'] check in wp-login.php.

Follow-up to [14556].

Props wplmillet, audrasjb.
Fixes #63147.