WordPress.org
Get WordPress

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#63193 closed defect (bug) (fixed)

REST should be capitalized in error message

Reported by: tobifjellner's profile tobifjellner Owned by: audrasjb's profile audrasjb
Milestone: 6.8 Priority: normal
Severity: normal Version: trunk
Component: REST API Keywords: fixed-major dev-reviewed i18n-change
Focuses: rest-api Cc:

Description

In WordPress 6.8 RC at
​https://build.trac.wordpress.org/browser/branches/6.8/wp-includes/rest-api.php?marks=437#L437
there is an error message:

'The rest route parameter must be a string.'

In this case, REST should be capitalized.

Change History (10)

#1 @sabernhardt
3 months ago

  • Component changed from Administration to REST API
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 6.8

[59886] added the error message, and it would need to be changed in the unit test too.

This ticket was mentioned in ​PR #8613 on ​WordPress/wordpress-develop by ​@abcd95.
3 months ago #2

  • Keywords has-patch has-unit-tests added; needs-patch removed

#3 @audrasjb
3 months ago

Good point. Self assigning for review.

#4 @audrasjb
3 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

#5 @audrasjb
3 months ago

  • Keywords commit added

The PR looks good. There is a coding standard issue but I'll fix it directly when committing the patch.

#6 @audrasjb
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 60104:

REST API: Properly capitalize "REST" in translation strings.

Props tobifjellner, sabernhardt, abcd95.
Fixes #63193.

#7 @audrasjb
3 months ago

  • Keywords dev-feedback fixed-major added; has-patch has-unit-tests commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for second committer sign off.

#8 @jorbin
3 months ago

  • Keywords dev-reviewed commit added; dev-feedback removed

[60104] looks good to backport for 6.8

#9 @audrasjb
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 60105:

REST API: Properly capitalize "REST" in translation strings.

Reviewed by jorbin.
Merges [60104] to the 6.8 branch.
Props tobifjellner, sabernhardt, abcd95.
Fixes #63193.

#10 @sabernhardt
3 months ago

  • Keywords i18n-change added; commit removed
Note: See TracTickets for help on using tickets.