Make WordPress Core

Opened 7 months ago

Last modified 7 months ago

#63624 new defect (bug)

Twenty Fourteen: Quote block does not apply user-defined text color to citation

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch changes-requested
Focuses: css Cc:

Description

Steps to reproduce the issue :-

  1. Activate Twenty Fourteen theme.
  2. Choose Quote block.
  3. Add some text.
  4. Change color from parent Quote.

You can able to see that applied color is not applicable on the citation.

Attachments (1)

63624.patch (368 bytes) - added by nidhidhandhukiya 7 months ago.

Download all attachments as: .zip

Change History (3)

#1 @abcd95
7 months ago

Bug Reproduction and Patch Test Report

This report validates whether the indicated patch works as expected.

Patch tested: 63624.patch

Environment

  • WordPress: 6.9-alpha-60093-src
  • PHP: 8.2.25
  • Browser: Chrome 137.0.0.0
  • OS: macOS
  • Theme: Twenty Fourteen 4.2

Actual Results

🟡 Issue partially resolved with the patch, but there is more to be done.

The change that this patch removes was added in [43797] to make sure they match the theme’s existing HTML element styles.

Additional Notes

The patch successfully addresses the quote text styling issues, with styles being applied correctly on both the frontend and in the editor. However, a partial issue remains with the citation text styling.

While the background color for citation text is being applied correctly in both contexts, the text color property is only taking effect on the frontend. In the editor, the citation text color is not being applied as expected due to CSS specificity conflicts.

The editor styles are overriding the intended citation text color due to the following CSS rule with higher specificity:

.wp-block-quote .wp-block-quote__citation {
    color: #2b2b2b; // ==> removing this makes editor styles work as expected
    font-size: 16px;
    font-weight: 400;
    margin-top: 0;
}

This change was also added in [43797] to make sure they match the theme’s existing HTML element styles.

#2 @sabernhardt
7 months ago

  • Focuses css added
  • Keywords has-patch changes-requested added
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Twenty Fourteen :- Quote block having issue with the text color. to Twenty Fourteen: Quote block does not apply user-defined text color to citation
  • Version 6.8 deleted

63624.patch would change the default citation color, for anyone who did not select a color in Quote block settings.

[55228] added an inherit rule for Pullquote blocks that have text or background color, and a similar solution for the Quote block should not need to be as elaborate as that.

Note: See TracTickets for help on using tickets.