WordPress.org
Get WordPress

Make WordPress Core

Opened 8 months ago

Closed 8 months ago

#63644 closed defect (bug) (fixed)

Twenty Seventeen: add PHPDoc block for the twentyseventeen_should_show_featured_image filter

Reported by: pmbaldha's profile pmbaldha Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.9 Priority: normal
Severity: normal Version: 6.6
Component: Bundled Theme Keywords: has-patch
Focuses: docs Cc:

Description (last modified by sabernhardt)

The Twenty Seventeen theme lacks a PHPDoc block for the twentyseventeen_should_show_featured_image filter. For more information, refer to ​https://github.com/WordPress/wordpress-develop/blob/6.8.1/src/wp-content/themes/twentyseventeen/functions.php#L711.

Please add the PHPDoc block for it as described on ​https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#4-hooks-actions-and-filters.

Change History (4)

This ticket was mentioned in ​PR #9167 on ​WordPress/wordpress-develop by ​@pmbaldha.
8 months ago #1

  • Keywords has-patch added

#2 @sabernhardt
8 months ago

  • Description modified (diff)
  • Focuses docs added; coding-standards removed
  • Summary changed from Missing PHPDoc block for the twentyseventeen_should_show_featured_image filter in Twenty Seventeen theme to Twenty Seventeen: add PHPDoc block for the twentyseventeen_should_show_featured_image filter
  • Version set to 6.6

[58206] introduced twentyseventeen_should_show_featured_image

#3 @SergeyBiryukov
8 months ago

  • Milestone changed from Awaiting Review to 6.9

#4 @SergeyBiryukov
8 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 60418:

Twenty Seventeen: Document the twentyseventeen_should_show_featured_image filter.

Follow-up to [58206].

Props pmbaldha, kishanjasani, mukesh27, sabernhardt, SergeyBiryukov.
Fixes #63644.

Note: See TracTickets for help on using tickets.