Make WordPress Core

Opened 6 months ago

Closed 4 months ago

#63799 closed enhancement (fixed)

Add support for border radius presets

Reported by: aaronrobertshaw's profile aaronrobertshaw Owned by: andrewserong's profile andrewserong
Milestone: 6.9 Priority: normal
Severity: normal Version: 6.9
Component: Editor Keywords: gutenberg-merge has-patch has-unit-tests
Focuses: Cc:

Description

This ticket tracks the backport of PHP files for the following Gutenberg updates:

https://github.com/WordPress/gutenberg/pull/67544

These updates including the border radius settings definition for theme.json as well as configuration for the style engines generation of CSS vars.

Further background and context is available within the original issue:

https://github.com/WordPress/gutenberg/issues/64041

Change History (7)

This ticket was mentioned in PR #9406 on WordPress/wordpress-develop by @aaronrobertshaw.


6 months ago
#1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/63799#ticket

This PR brings the changes from the following Gutenberg PRs to core:

https://github.com/WordPress/gutenberg/pull/67544

Changes include:

  • definitions of presets settings for theme.json
  • CSS var settings for style engine

#2 @rollybueno
6 months ago

We need to wait for https://github.com/WordPress/gutenberg/pull/67544 review approval and merging first.

This ticket was mentioned in PR #10113 on WordPress/wordpress-develop by @andrewserong.


4 months ago
#3

  • Keywords has-unit-tests added

This PR builds on what was proposed in #9406, but adds tests and fixes up an issue where the former PR didn't yet update the valid settings array.

Trac ticket: https://core.trac.wordpress.org/ticket/63799#ticket

This PR brings the changes from the following Gutenberg PR to core: https://github.com/WordPress/gutenberg/pull/67544 for support for border radius presets.

Changes include:

  • definitions of presets settings for theme.json
  • CSS var settings for style engine

@andrewserong commented on PR #9406:


4 months ago
#4

Thanks for putting this PR together! While you're not around this week, I've opened up an alternate PR building on this one over in #10113 (it does the same but just adds some tests). I'll close this PR out for now and we can look at merging in #10113 for 6.9.

#5 @andrewserong
4 months ago

  • Milestone changed from Awaiting Review to 6.9

@andrewserong commented on PR #10113:


4 months ago
#6

Thanks folks! I'll commit this tomorrow 👍

#7 @andrewserong
4 months ago

  • Owner set to andrewserong
  • Resolution set to fixed
  • Status changed from new to closed

In 60892:

Editor: introduce border.radiusSizes support in theme.json.

Adds site front end rendering logic for the border.radiusSizes border radius presets, as well as the required logic in WP_Theme_JSON and the style engine.

Props aaronrobertshaw, youknowriad, ramonopoly, poena, joen, jameskoster, richtabor, asafm7, fabiankaegy
Fixes #63799.

Note: See TracTickets for help on using tickets.