WordPress.org
Get WordPress

Make WordPress Core

Opened 10 hours ago

Closed 9 hours ago

Last modified 7 hours ago

#64197 closed defect (bug) (fixed)

Make daylight saving time date/time editable

Reported by: timse201's profile timse201 Owned by: jorbin's profile jorbin
Milestone: 6.9 Priority: normal
Severity: normal Version: trunk
Component: Date/Time Keywords: has-patch commit
Focuses: administration Cc:

Description

The date/time function for daylight saving time is split into 2 functions. For German, we use a "," or "um" between date/time. Can we move this to a more editable string, please.

​https://github.com/WordPress/wordpress-develop/blob/7e36c645c8a11c68522a5da8af5c8b9dc8ee973c/src/wp-admin/options-general.php#L448

Change History (9)

#1 @pbearne
10 hours ago

  • Owner set to pbearne
  • Status changed from new to assigned

This ticket was mentioned in ​PR #10464 on ​WordPress/wordpress-develop by ​@pbearne.
10 hours ago #2

  • Keywords has-patch added

Included the space in the date/time format

Trac ticket: [](https://core.trac.wordpress.org/ticket/64197)

#3 @pbearne
10 hours ago

  • Component changed from Administration to Date/Time

@timse201 Thanks for the report

It looks like a simple fix, so I have created a patch.

Can you review the patch and confirm that it will resolve the issue?

Paul

This ticket was mentioned in ​Slack in #core by pbearne. ​View the logs.
10 hours ago

#5 @timse201
10 hours ago

LGTM
thank you

#6 @jorbin
9 hours ago

  • Milestone changed from Awaiting Review to 6.9
  • Owner changed from pbearne to jorbin

Self assigning for review

#7 @johnjamesjacoby
9 hours ago

  • Focuses administration added
  • Keywords commit added

#8 @johnjamesjacoby
9 hours ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 61133:

Options: Combine date & time strings to improve translation accuracy.

This commit merges 2 separate translatable strings into 1 (with a translator note) to make its Daylight-Saving-Time-specific context easier to identify & understand.

Props jorbin, pbearne, timse201.

Fixes #64197.

​@SergeyBiryukov commented on ​PR #10464:
7 hours ago #9

Thanks for the PR! This was merged in r61133.

Note: See TracTickets for help on using tickets.