Make WordPress Core

Opened 3 months ago

Closed 2 months ago

Last modified 2 months ago

#64257 closed defect (bug) (invalid)

Admin: Incorrect CSS selector in about.css causing unintended styling

Reported by: passoniate's profile passoniate Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch
Focuses: css Cc:

Description

While reviewing the admin CSS file (wp-admin/css/about.css), I found an incorrect selector:

Change History (7)

This ticket was mentioned in PR #10521 on WordPress/wordpress-develop by @passoniate.


3 months ago
#1

Fix incorrect CSS selector in about.css causing unintended styling.

#2 @sabernhardt
3 months ago

  • Component changed from Administration to Help/About
  • Keywords reporter-feedback added

Could you share what is displaying incorrectly?

I do not find the .about-wrap class used anywhere now. [45278] added the .about-wrap .column :first-child selector for WordPress 5.2, and then 5.3 replaced the .about-wrap class in [46616].

@mukesh27 commented on PR #10521:


2 months ago
#3

Instead of updating the CSS we have to remove that CSS. See https://core.trac.wordpress.org/ticket/64257#comment:2

#4 @westonruter
2 months ago

  • Keywords needs-screenshots added

#5 follow-up: @ryelle
2 months ago

  • Resolution set to invalid
  • Status changed from new to closed

This is in the legacy CSS. It was decided as part of the layout restructure in [46616] to not remove this CSS as some plugins used the about layout markup for their own update pages. By now we can likely remove this whole section of CSS ("x.2.0 - Legacy About Styles: Global" and below), but I would suggest opening a new ticket for that & getting it in early next release.

The selector in question is also not wrong — it's meant to reset the margin on the first item inside a column.

#6 in reply to: ↑ 5 @sabernhardt
2 months ago

  • Keywords reporter-feedback needs-screenshots removed
  • Milestone Awaiting Review deleted
  • Version trunk deleted

some plugins used the about layout markup for their own update pages.

A directory search found hundreds of plugins that have used the .about-wrap class, and likely many of them still depend on the legacy CSS.

Note: See TracTickets for help on using tickets.