![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 9 months ago
Closed 8 months ago
#64429 closed defect (bug) (fixed)
Script Modules: Dependencies inherit fetchpriority from not-enqueued, registered modules
| Reported by: | jonsurrell | Owned by: | westonruter |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.9.1 |
| Component: | Script Loader | Version: | 6.9 |
| Severity: | normal | Keywords: | has-patch has-unit-tests fixed-major |
| Cc: | Focuses: | javascript |
Description (last modified by )
In PR 10638 (comment), it was noticed that a script module's fetchpriority may increased to match its dependent's fetchpriority even if that module is not enqueued.
It seems that the dependency's fetchpriority should only increase when an enqueued dependent has a higher fetchpriority, not when any registered dependent has a higher fetchpriority.
[60931] added the logic for module dependencies to increase their fetch priority.
Change History (13)
This ticket was mentioned in PR #10651 on WordPress/wordpress-develop by @westonruter.
9 months ago
#2
- Keywords has-patch has-unit-tests added
Trac ticket: https://core.trac.wordpress.org/ticket/64429
#3
@
9 months ago
- Milestone Awaiting Review → 7.0
- Owner set to
- Status new → accepted
- Version → 6.9
No, this is not expected. Working on a fix.
#4
@
9 months ago
When WP_Script_Modules::print_script_module() was calculating the highest fetchpriority for its script module dependents, it was not considering whether those dependents were actually enqueued. Now it does.
Note the issue was not present for classic scripts.
Test cases have been added for scripts and script modules.
Ready for review: https://github.com/WordPress/wordpress-develop/pull/10651
#5
@
9 months ago
This isn't a critical issue but it was introduced in 6.9 and could be considered for a 6.9.x patch release.
#9
@
9 months ago
- Keywords fixed-major added
- Resolution fixed
- Status closed → reopened
Re-opening for 6.9 backport consideration.
@westonruter Do you recall if this was the expected behavior?