wp.updates.l10n.updating is deprecated notice

[Presskopp]

I got a notice wp.updates.l10n.updating is deprecated since version 5.5.0! Use wp-i18n instead.. The corresponding code ist to find on line 1280 in theme.js:

.find( 'p' ).text( wp.updates.l10n.updating );

[Presskopp]

Patch:

.find( 'p' ).text( wp.i18n.__( 'Updating...' ) );

Resolved

Trac ticket:

## Use of AI Tools

Thanks for the PR! 🙌

Could you please connect your WordPress.org account with your GitHub account?

You can follow the instructions here:
​https://make.wordpress.org/core/2020/03/19/associating-github-accounts-with-wordpress-org-profiles/

I intentionally chose “Updating...” (3 dots) instead of “Updating...” (ellipsis) because that string already exists.

Fixes a deprecated JavaScript usage in the WordPress admin.

The code in wp-admin/js/theme.js was using wp.updates.l10n.updating, which has been deprecated since WordPress 5.5. This PR replaces it with the recommended wp.i18n.() function.

Testing Instructions

Go to Dashboard → Updates or Appearance → Themes

Trigger a theme update

Confirm:

The text “Updating...” appears correctly

No deprecation notice appears in the browser console

Trac Ticket

Fixes: https://core.trac.wordpress.org/ticket/64619

I see there are quite a few reads of the l10n object as well. Should those not be updated as well?

There is a seeming duplicate PR opened at the same time: #10896. Should this be close in favor of that, or the other way around?

There is a seeming duplicate PR opened at the same time: #10895. Should this be close in favor of that, or the other way around?

Thanks for the review, @westonruter.
I checked theme.js and found that line 1280 already uses wp.i18n.('Updating...') instead of wp.updates.l10n.updating. I didn't find other direct references to wp.updates.l10n in this file.
Could you point to the specific instances you're seeing? I can:
Check other files if they're outside theme.js
Review the PR diff if there are other patterns to update
Look for indirect uses I might have missed
I want to make sure all deprecated wp.updates.l10n usages are replaced with wp.i18n.().

Here:

​https://github.com/manishdhorepatil-art/wordpress-develop/blob/f9275dffaf4ed5c3626b13b32414929ed8ae48c2/src/js/_enqueues/wp/theme.js#L122

​https://github.com/manishdhorepatil-art/wordpress-develop/blob/f9275dffaf4ed5c3626b13b32414929ed8ae48c2/src/js/_enqueues/wp/theme.js#L976-L978

And so on.

@westonruter Could you please checknow added nessary changes

@westonruter what else changes are necessary

I'm not an expert on i18n in JS, so it will be best for someone else who has more experience to provide final review, but I'm sharing what I believe needs to be done.

@westonruter done please check now

@westonruter can you check now done suggested changes

@manishdhorepatil-art That looks correct. I'll leave for another contributor who has I18N expertise to confirm.

Please don't keep merging trunk into this branch. It's not necessary unless there is a merge conflict. Please wait for another reviewer.

@westonruter do we need any changes to this ticket ?

I don't know. It's waiting for another reviewer.

Please don't keep merging trunk into this branch. It's not necessary unless there is a merge conflict. Please wait for another reviewer.

@huzaifaalmesbah can you pls review this

Hi @manishdhorepatil-art,
I see that @westonruter has already reviewed this and mentioned it is waiting for another reviewer with more i18n expertise. So it’s better to wait for a committer or component maintainer to review it.

No need to rush or worry too much. please wait for the appropriate reviewer.

While searching for l10n.updating I found that it's also being used in /js/_enqueues/wp/customize/controls.js as follows on like 7296

section.contentContainer.find( '.customize-action' ).text( api.l10n.updating );

I'm not sure whether this should be fixed as well.

[audrasjb]

As per today's 7.0 pre-RC1 bug scrub:
As we're a few hours from 7.0 RC1, I'm moving this ticket to milestone 7.1 to give it more time for testing.

@westonruter its been long are there any changes in the pr expected

[wildworks]

Since ​PR 10896 was submitted several months ago, we need to re-review it to move this ticket forward. Otherwise, we will punt this ticket to 7.2.

Closing this in favor of #10896. #10896 appears to resolve more issues.

[wildworks]

Punting this to 7.2 as the 7.1 RC1 release is imminent. Let's wait for reviews from contributors who are more familiar with internationalization.