Make WordPress Core

Opened 8 weeks ago

Closed 7 weeks ago

#64720 closed defect (bug) (fixed)

Empty gray theme-actions div on Appearance > Themes for classic themes with no customizer support

Reported by: awetz583's profile awetz583 Owned by: joedolson's profile joedolson
Milestone: 7.0 Priority: normal
Severity: minor Version: trunk
Component: Themes Keywords: has-screenshots admin-reskin has-patch commit
Focuses: css Cc:

Description

If a Classic/Hybrid theme that has the Customizer disabled is active in the Appearance > Themes screen, there is a stray gray box in the bottom right corner of theme's box.

This appears to be because there is an empty div <div class="theme-actions"> </div> that has corresponding CSS to add a gray background and some padding.

For most themes, there is a Customize button there. It would be great if this div was removed or they styles were changed if it was empty of buttons.

I can see this issue in 6.9, but it is much more noticeable in 7.0 Beta 1 because the background color for the active h2.theme-name has been changed from dark gray #1d2327 to bright blue #3858e9

Attachments (1)

Screenshot 2026-02-24 at 4.17.57 PM.png (15.0 KB) - added by awetz583 8 weeks ago.
Bottom of an active classic theme that does not have a customize button

Download all attachments as: .zip

Change History (11)

@awetz583
8 weeks ago

Bottom of an active classic theme that does not have a customize button

#1 @joedolson
8 weeks ago

  • Component changed from General to Themes
  • Focuses css added
  • Keywords has-screenshots needs-patch admin-reskin added
  • Milestone changed from Awaiting Review to 7.0
  • Type changed from enhancement to defect (bug)

#2 @joedolson
7 weeks ago

  • Owner set to joedolson
  • Status changed from new to accepted

This ticket was mentioned in PR #11121 on WordPress/wordpress-develop by @joedolson.


7 weeks ago
#3

  • Keywords has-patch added; needs-patch removed

Changes the active theme actions panel to have no background color to avoid possibility of empty background.

Trac ticket: https://core.trac.wordpress.org/ticket/64720

## Use of AI Tools

@joedolson commented on PR #11121:


7 weeks ago
#4

After change:

https://github.com/user-attachments/assets/c9061e71-ae50-4ace-89d5-02666c903a57

With customizer disabled:

https://github.com/user-attachments/assets/271e573e-b4c2-41b0-880f-db45e10f640d

Before, with customizer enabled:

https://github.com/user-attachments/assets/3e0b3e1d-9e89-48d5-8e4d-fa50a8382363

@huzaifaalmesbah commented on PR #11121:


7 weeks ago
#5

It looks good after this PR, but I still notice a very minor box-shadow when the Customizer is disabled.
https://github.com/user-attachments/assets/bd8f7dfb-361d-460c-9b51-d535fc6783e2

#6 @noruzzaman
7 weeks ago

Test Report

Patch tested: https://github.com/WordPress/wordpress-develop/pull/11121

Environment

  • WordPress: 7.0-beta2-61809
  • PHP: 8.3.30
  • Server: PHP.wasm
  • Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
  • Browser: Chrome 145.0.0.0
  • OS: macOS
  • Theme: Twenty Fourteen 4.4
  • MU Plugins: None activated
  • Plugins:
    • Disable Customizer 2.2.7
    • Test Reports 1.2.1

Actual Results

  1. ✅ The primary issue addressed by the patch is resolved.
  1. ⚠️ A minor visual issue still remains.

The .theme-actions container still renders a small box-shadow (inset 0 1px 0 rgba(0,0,0,0.1)), which creates a thin visual line in the active theme bar.

Before After
https://i.ibb.co.com/prQXzsNm/Before.png https://i.ibb.co.com/ZzbtmSRf/After.png

@shailu25 commented on PR #11121:


7 weeks ago
#7

The PR works as expected; we just need to address the box-shadow issue when customizer disable.

|Before|After|After with Customizer Button

| https://github.com/user-attachments/assets/1fd0bfd8-8e1e-4fed-a994-00f0a06fa3a4|https://github.com/user-attachments/assets/27724416-3951-40e8-8a36-ff1cdd99ef72|https://github.com/user-attachments/assets/9202cae1-79e1-456f-8f43-3d059148f058

@joedolson commented on PR #11121:


7 weeks ago
#8

I removed the box-shadow on the active theme actions container. It was pretty much entirely invisible when the customizer was active, so the only case where you could really see it was this one.

#9 @joedolson
7 weeks ago

  • Keywords commit added

#10 @joedolson
7 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 61831:

Themes: Remove background on active theme actions.

The background behind theme actions for the active theme was still visible when no actions were available, such as with a disabled customizer. Removing the background on this container improves the design of the active theme card by simplifying the layout and prevents the appearance of an error if no actions are available.

Remove background and inset box shadow for the .theme.active .theme-actions container on the active theme.

Props awetz583, huzaifaalmesbah, noruzzaman, shailu25, joedolson.
Fixes #64720.

Note: See TracTickets for help on using tickets.