Make WordPress Core

Opened 7 weeks ago

Closed 4 weeks ago

#64962 closed defect (bug) (fixed)

Install screens: “Log In” and "Support link" use old color

Reported by: huzaifaalmesbah's profile huzaifaalmesbah Owned by: audrasjb's profile audrasjb
Milestone: 7.0 Priority: normal
Severity: normal Version: trunk
Component: Administration Keywords: admin-reskin has-patch has-screenshots dev-reviewed
Focuses: ui, css Cc:

Description

In the WordPress install flow, links such as “Read the support article on wp-config.php” and “Log In” are using the outdated link color instead of the updated admin color.

Attachments (3)

Huzaifa-20260327003915.png (647.5 KB) - added by huzaifaalmesbah 7 weeks ago.
Huzaifa-20260327004150.png (655.9 KB) - added by huzaifaalmesbah 7 weeks ago.
Huzaifa-20260327005931.png (437.4 KB) - added by huzaifaalmesbah 7 weeks ago.

Download all attachments as: .zip

Change History (27)

#1 @audrasjb
7 weeks ago

  • Focuses ui css added
  • Keywords admin-reskin added

#2 @sumitsingh
7 weeks ago

🐞 Bug occurs

PHP: 8.1
WordPress Version: 7.0-RC2

Last edited 7 weeks ago by sumitsingh (previous) (diff)

This ticket was mentioned in PR #11373 on WordPress/wordpress-develop by @hbhalodia.


7 weeks ago
#3

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/64962

## Description

  • Add CSS variable for install.css changes.
  • Add color hex code for wp_die functions.php code, as the variable was not added before that it executed wp_die.
  • Also added fix for setup-config.php if config already exists and related anchors. See before and after Screenshots.
BeforeAfter
https://github.com/user-attachments/assets/38236e5a-a22d-4b96-8fc9-baba21b9423b https://github.com/user-attachments/assets/1273066d-91ff-42ee-84d3-8b0aead9dc44

## Use of AI Tools

  • None

#4 @SergeyBiryukov
7 weeks ago

  • Milestone changed from Awaiting Review to 7.0

@audrasjb commented on PR #11373:


7 weeks ago
#5

Before:
https://github.com/user-attachments/assets/54ea8c43-4bea-4dd5-bf64-253ee906f92c

After:
https://github.com/user-attachments/assets/d1da7b6a-c61f-432a-9ca9-4c37fd793ad7

@audrasjb commented on PR #11373:


7 weeks ago
#6

Thanks for the PR, this looks good to me 👍

#7 @audrasjb
7 weeks ago

  • Component changed from General to Administration
  • Keywords commit has-screenshots added
  • Version set to trunk

Thanks for the PR, this is ready to ship.

#8 @audrasjb
7 weeks ago

  • Owner set to audrasjb
  • Status changed from new to accepted

#9 @audrasjb
7 weeks ago

I'm separating this in two commits, as the two patches are fixing the issue in very different locations and with a different implementation.

#10 @audrasjb
7 weeks ago

  • Keywords changes-requested added; commit removed

Wait, @hbhalodia are you sure these are the correct colors?
By the way we'll also want to update :focus colors and the other related styles (like the border/border-radius of the outline).

Removing commit for now.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


7 weeks ago

#12 @audrasjb
7 weeks ago

As per today's bug scrub:
I'm not 100% sure the proposed PR uses the good color values. I pinged the PR author but another check is welcome.
Invoking @wildworks or @sabernardt, just in case you can help to confirm the issue or not?

#13 @dhrumilk
6 weeks ago

I tested the changes locally using the provided updated code, and the updated link colors look consistent with the new admin design system. The “Log In” and support article links now match other admin link styles.

From my testing, the color values appear correct and align well with the intended UI refresh. Overall, the update looks good to me.

Last edited 6 weeks ago by dhrumilk (previous) (diff)

#14 @darshitrajyaguru97
5 weeks ago

Tested the changes locally with the updated code, and the link colors are now consistent with the revised admin design system. The “Log In” and support article links align well with other admin link styles, improving overall visual consistency.
From my review, the color values look accurate, and the update meets the intended UI expectations.

Last edited 5 weeks ago by darshitrajyaguru97 (previous) (diff)

#15 @ismail0071
5 weeks ago

Tested locally — link colors now match the new admin design system. “Log In” and support links are consistent with other admin styles. Overall, looks good.

Last edited 5 weeks ago by ismail0071 (previous) (diff)

#16 @vishitshah
5 weeks ago

Verified the updates in a local environment, and the revised link colors integrate well with the refreshed admin UI. The Log In and support links now follow a consistent styling pattern, enhancing visual clarity across the interface.

Last edited 5 weeks ago by vishitshah (previous) (diff)

#17 @mikinc860
5 weeks ago

The updates were successfully validated in a local environment, with the revised link colors aligning seamlessly with the refreshed admin UI. The Log In and support links now adhere to a consistent styling pattern, improving visual coherence and enhancing overall interface clarity.

#18 @Pooja N
5 weeks ago

Tested the changes locally and confirmed that the updated link colors align with the revised admin design system.

#19 @wildworks
5 weeks ago

PR 11373 needs to be updated. The correct color is not being used in some parts of the code. Please refer to this discussion.

cc @hbhalodia

#20 @wildworks
5 weeks ago

  • Keywords changes-requested removed

I think PR 11373 is ready for commit.

#21 @wildworks
5 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 62230:

Upgrade/Install: Use new default admin color scheme for links on the setup screen.

This changeset updates the link colors on the setup screen and the default wp_die() fallback styles to use the new default admin color scheme.

Props audrasjb, darshitrajyaguru97, dhrumilk, hbhalodia, huzaifaalmesbah, ismail0071, mikinc860, pooja-n, shailu25, sumitsingh, vishitshah, wildworks
Fixes #64962. See #64308.

#22 @wildworks
5 weeks ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening #64962 to request backporting [62230] to the 7.0 branch

#23 @audrasjb
4 weeks ago

  • Keywords dev-reviewed added; dev-feedback removed

Thanks. This is a second committer sign off.

#24 @audrasjb
4 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 62236:

Upgrade/Install: Use new default admin color scheme for links on the setup screen.

This changeset updates the link colors on the setup screen and the default wp_die() fallback styles to use the new default admin color scheme.

Reviewed by audrasjb, wildworks.
Merges [62230] to the 7.0 branch.

Props audrasjb, darshitrajyaguru97, dhrumilk, hbhalodia, huzaifaalmesbah, ismail0071, mikinc860, pooja-n, shailu25, sumitsingh, vishitshah, wildworks
Fixes #64962.
See #64308.

Note: See TracTickets for help on using tickets.