Make WordPress Core

Opened 4 days ago

Closed 2 days ago

#65009 closed defect (bug) (fixed)

Privacy: ”Copied!” text is misaligned

Reported by: wildworks's profile wildworks Owned by: mukesh27's profile mukesh27
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Privacy Keywords: admin-reskin has-patch dev-reviewed
Focuses: Cc:

Description

When the "Copy suggested policy text to clipboardCopy suggested policy text from WordPress." button is clicked, the text "Copied" is displayed to the left of the button.

The text and the button should be vertically aligned.

Attachments (1)

privacy-action-alignment.png (33.0 KB) - added by wildworks 4 days ago.

Download all attachments as: .zip

Change History (17)

#1 @anupkankale
4 days ago

I'm working on a bug for this. Will submit a PR shortly.

#65009 new defect (bug)

This ticket was mentioned in PR #11420 on WordPress/wordpress-develop by @anupkankale.


4 days ago
#2

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/65009

## Description
Fixes the vertical alignment of the Copied text that appears after clicking the Copy suggested policy text to clipboard button.

## Changes

  • Removed padding-top: 6px
  • Added vertical-align: middle

in src/wp-admin/css/edit.css

## Testing

  1. Go to wp-admin/options-privacy.php
  2. Click the Copy button next to any policy section
  3. The Copied text should now be vertically aligned with the button

#3 @mukesh27
4 days ago

  • Keywords changes-requested added

This ticket was mentioned in PR #11421 on WordPress/wordpress-develop by @mukesh27.


4 days ago
#4

Trac ticket: https://core.trac.wordpress.org/ticket/65009

## Use of AI Tools

No

@mukesh27 commented on PR #11421:


4 days ago
#5

After PR changes:

https://github.com/user-attachments/assets/5cef9a35-cbc7-4dc1-8073-f0210ff952e6

#6 @mukesh27
4 days ago

  • Keywords changes-requested removed
  • Owner set to mukesh27
  • Status changed from new to assigned

@audrasjb commented on PR #11421:


4 days ago
#7

This looks good to me on both desktop:
https://github.com/user-attachments/assets/c2aa1f17-9f3b-45c6-ae94-b168e8fd605e

and mobile:
https://github.com/user-attachments/assets/e4b149a0-e2f6-459a-99dc-306b15d6f691

oops, the text disappeared on the mobile screenshot. But well, trust me it looked good! '

This ticket was mentioned in PR #11424 on WordPress/wordpress-develop by @kapilpaul.


4 days ago
#8

Trac ticket: https://core.trac.wordpress.org/ticket/65009

## Use of AI Tools

@shailu25 commented on PR #11421:


4 days ago
#9

  • Privacy: ”Copied!” Text is now aligned✅
BeforeAfter
https://github.com/user-attachments/assets/e980cbb6-294e-4508-b2c5-821e8c0120c7https://github.com/user-attachments/assets/60d0f560-1965-4e43-a160-430864c1d43a

@shailu25 commented on PR #11424:


4 days ago
#10

Duplicate of #11421

#11 @SergeyBiryukov
4 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 62196:

Admin Reskin: Correct ”Copied!” text alignment on Privacy Policy Guide screen.

Follow-up to [61645].

Props mukesh27, wildworks, audrasjb, shailu25, anupkankale, kapilpaul, SergeyBiryukov.
Fixes #65009.

#12 @SergeyBiryukov
4 days ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 7.0 consideration.

#13 @SergeyBiryukov
4 days ago

  • Keywords commit dev-feedback added

#14 @wildworks
3 days ago

Reopening for 7.0 consideration.

Approved

#15 @wildworks
3 days ago

  • Keywords dev-reviewed added; commit dev-feedback removed

#16 @SergeyBiryukov
2 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 62203:

Admin Reskin: Correct ”Copied!” text alignment on Privacy Policy Guide screen.

Follow-up to [61645].

Reviewed by wildworks, SergeyBiryukov.
Merges [62196] to the 7.0 branch.

Props mukesh27, wildworks, audrasjb, shailu25, anupkankale, kapilpaul, SergeyBiryukov.
Fixes #65009.

Note: See TracTickets for help on using tickets.