![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#65325 closed defect (bug) (fixed)
Real-time collaboration files have shipped in 7.0
| Reported by: | johnbillion | Owned by: | desrosj |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.0.3 |
| Component: | Editor | Version: | 7.0 |
| Severity: | minor | Keywords: | has-patch fixed-major |
| Cc: | Focuses: | coding-standards |
Description
The real-time collaboration (RTC) files that were removed in #65205 have unintentionally shipped in the 7.0 package due to an issue with the build server not fully removing deleted files.
The wp-includes/collaboration files no longer exist in source control but they are present in the package zip file.
The impact is mostly benign as the files are not loaded via wp-settings.php or instantiated anywhere else, but the fact that this happened and nobody noticed it until after the release is a problem.
This is technically a meta issue but as it affects the released 7.0 package let's track it here too.
Status
- Not present in https://core.trac.wordpress.org/browser/tags/7.0/src/wp-includes
- Not present in https://github.com/WordPress/wordpress-develop/tree/7.0.0/src/wp-includes
- Fully present in 7.0 tag of https://github.com/WordPress/WordPress/tree/7.0/wp-includes/collaboration
- Present as empty files in trunk branch of https://github.com/WordPress/WordPress/tree/master/wp-includes/collaboration
- Present as empty files on https://core.svn.wordpress.org/trunk/wp-includes/collaboration/
- Present as an empty directory on https://develop.svn.wordpress.org/trunk/src/wp-includes/collaboration/
- Fully present in package at https://wordpress.org/wordpress-7.0.zip
Impact
- The developer.wordpress.org reference site is showing the collaboration classes as existing since 7.0.0. Example: https://developer.wordpress.org/reference/classes/wp_sync_post_meta_storage/
- The build server will likely break again when those files are reintroduced at a later date.
I've put this in the 7.0.1 milestone for visibility. I don't know if it's necessary to remove those files in 7.0.1.
Change History (24)
This ticket was mentioned in PR #11959 on WordPress/wordpress-develop by @khokansardar.
8 weeks ago
#3
- Keywords has-patch added
## Summary
- Adds real-time collaboration files to the
$_old_filesarray inupdate-core.phpso they are removed during core upgrades. - Addresses #65325, where RTC files removed in [62334] were unintentionally included in the WordPress 7.0 release package due to a build server issue.
- The existing
verify:old-filesGrunt task will also fail builds if these files are present in thebuild/directory, preventing recurrence.
## Context
Real-time collaboration was removed from core in #65205 (62334, 62337, 62338 on the 7.0 branch). However, the files still shipped in wordpress-7.0.zip and the WordPress/WordPress 7.0 tag. The impact is mostly benign since the files are not loaded, but they should be cleaned up on upgrade and excluded from future builds.
## Test plan
- [ ] Verify
php -l src/wp-admin/includes/update-core.phppasses - [ ] Verify PHPCS reports no errors on the changed file
- [ ] Confirm
build/wp-includes/collaboration/does not exist locally - [ ] Run
npx grunt verify:old-filesas part of a full build in CI - [ ] Confirm upgrading from a 7.0.0 install with RTC files to 7.0.1 removes:
wp-includes/collaboration.phpwp-includes/collaboration/class-wp-http-polling-sync-server.phpwp-includes/collaboration/class-wp-sync-post-meta-storage.phpwp-includes/collaboration/interface-wp-sync-storage.php
## Backport
This change should be backported to the 7.0 branch for the 7.0.1 milestone.
#4
follow-up:
↓ 8
@
8 weeks ago
Affects sync.js and sync.min.js too:
Only in package/wp-includes: collaboration Only in package/wp-includes: collaboration.php Only in package/wp-includes/js/dist: sync.js Only in package/wp-includes/js/dist: sync.min.js
This ticket was mentioned in Slack in #core by jorbin. View the logs.
4 weeks ago
@masteradhoc commented on PR #11959:
3 weeks ago
#6
Hey @itzmekhokan
Can you check the last comment by @johnbillion on core trac? https://core.trac.wordpress.org/ticket/65325#comment:4
We'd like to get this ready for WP 7.0.1 to be included if possible.
@khokansardar commented on PR #11959:
3 weeks ago
#7
Hey @itzmekhokan Can you check the last comment by @johnbillion on core trac? https://core.trac.wordpress.org/ticket/65325#comment:4 We'd like to get this ready for WP 7.0.1 to be included if possible.
Hey @masteradhoc I've addressed the mentioned feedback.
#8
in reply to: ↑ 4
@
3 weeks ago
Replying to johnbillion:
Affects sync.js and sync.min.js too:
Only in package/wp-includes: collaboration Only in package/wp-includes: collaboration.php Only in package/wp-includes/js/dist: sync.js Only in package/wp-includes/js/dist: sync.min.js
Thanks @johnbillion addressed with commit https://github.com/WordPress/wordpress-develop/pull/11959/changes/d8d0bd735f628d33e732643eb8d4834e0cd911fe
#9
@
3 weeks ago
- Milestone 7.0.1 → 7.0.2
As the RC for WP 7.0.1 is expected to land tomorrow we'll have to punt this to 7.0.2.
#12
@
6 days ago
I've opened a request on the Make Systems site asking for this to be investigated prior to 7.1 RC1: https://make.wordpress.org/systems/2026/07/13/build-server-not-removing-files-from-core-svn-wordpress-org-when-it-should/
#13
@
4 days ago
The Systems team has fixed the issue on the build server and the missed changes were included in changeset 62042 attached to [62758].
I’ve verified that the state of the core.svn.w.org repository after 62042 is correct. All of the files that should be present are, and all of the files that should have been deleted are now gone.
I also confirmed that the 7.1-beta1 release is in the correct state.
Because they shipped in WordPress, these real-time collaboration related files should likely still be added to the $_old_files list.
Related commits:
Trunk:
7.0 Branch:
Oddly, running
npm run buildon wordpress-develop locally before and after the 7.0 branch's commit above does remove the files from thebuilddirectory.r62069 (trunk, "Build/Test Tools: Force run
grunt clean --devbefore build.") was committed as a followup to r61438. @desrosj I can't see if this was backported, do you think this would resolve the issue reported here?