Opened 23 hours ago
Last modified 19 hours ago
#65712 new defect (bug)
Forward multisite settings in the fork test matrix to improve CI efficiency
| Reported by: | lancewillett | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | Build/Test Tools | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | tests, multisite |
Description
Scoped in PR https://github.com/WordPress/wordpress-develop/pull/12693
The limited-matrix-for-forks job in .github/workflows/phpunit-tests.yml declares three multisite include rows but does not forward the multisite or phpunit-config inputs to the reusable workflow.
Those rows fall back to the single-site defaults (phpunit.xml.dist), so: two exactly duplicate existing single-site jobs, and the intended multisite coverage on personal forks never runs.
The test-with-mysql, test-with-mariadb, and innovation-release callers already forward both inputs. This change makes limited-matrix-for-forks do the same, so the multisite rows load tests/phpunit/multisite.xml correctly.
Scope and impact (personal forks outside WordPress/ only; canonical matrices unchanged):
- Job count stays at 8 (no added runner load)
- Removes 2 redundant single-site jobs
- Restores 3 multisite jobs (0 effective before)
- Distinct test configurations go from 6 to 8
Change History (2)
This ticket was mentioned in PR #12693 on WordPress/wordpress-develop by @lancewillett.
23 hours ago
#1
@lancewillett commented on PR #12693:
19 hours ago
#2
For reviewers: this PR changes the limited-matrix-for-forks job which by design runs only on personal forks (its if excludes the WordPress/ org), so this PR's own CI doesn't exercise it.
It forwards multisite and phpunit-config to the reusable workflow, matching the test-with-mysql and test-with-mariadb callers. The 3 multisite: true include rows now load tests/phpunit/multisite.xml instead of falling back to single-site, restoring multisite coverage without adding or removing jobs.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
## Trac ticket
https://core.trac.wordpress.org/ticket/65712
## What
The
limited-matrix-for-forksjob inphpunit-tests.ymldeclares multisite include rows but never forwardsmultisiteorphpunit-configto the reusable workflow. Those rows fall back to single-site defaults, so each one duplicates an existing single-site job instead of exercising multisite.This forwards both inputs so the multisite rows select
tests/phpunit/multisite.xml, matching thetest-with-mysql,test-with-mariadb, and innovation-release callers.## Why
The fork matrix currently spends jobs on duplicate single-site runs and skips the multisite coverage it intends to provide. The fix restores that coverage without adding or removing any jobs.
## Expected impact
Scope: the
limited-matrix-for-forksjob only. It runs on personal forks outside theWordPress/organization, so the canonical matrices are untouched.multisite: truerows now loadtests/phpunit/multisite.xml.A healthy run shows three jobs configured with
tests/phpunit/multisite.xmland no increase in total job count.## Definition of done
A reviewer can validate and verify the change as follows:
multisiteandphpunit-configinlimited-matrix-for-forksonly, matching thetest-with-mysqlcaller.actionlintpasses onphpunit-tests.yml.tests/phpunit/multisite.xmlas the PHPUnit config; the single-site jobs still showphpunit.xml.dist.test-with-mysql,test-with-mariadb, ortest-innovation-releases.## Testing
actionlintpasses on the changed workflow.tests/phpunit/multisite.xml; single-site rows are unchanged.WordPress/organization, so it does not affect the canonical CI.