WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6892 closed defect (bug) (fixed)

Missing comment notification on approval

Reported by: chmac Owned by:
Milestone: 2.6 Priority: normal
Severity: major Version: 2.5
Component: General Keywords:
Focuses: Cc:

Description

If you approve a comment via edit-comments.php, and the option comments_notify = 1, no email is generated, the author is not notified. This bug was introduced when moderation.php functionality was moved into edit-comments.php. The code which is now missing was:

if ( get_option( 'comments_notify' ) == true ) {
    wp_notify_postauthor( $k );
}

The moderation notification is not the same, it sends a notification to the admin_email, not the post author.

Attachments (2)

notify-on-approve.patch (613 bytes) - added by chmac 6 years ago.
My second patch passed the wrong variable for the $comment_id - I've tested this patch and it works on my install.
6892.diff (1.3 KB) - added by MtDewVirus 6 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 chmac6 years ago

  • Milestone changed from 2.7 to 2.5.2
  • Version set to 2.5

chmac6 years ago

My second patch passed the wrong variable for the $comment_id - I've tested this patch and it works on my install.

comment:2 ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7917]) Resurrect comment approval notification. Props chmac. fixes #6892 for trunk

comment:3 ryan6 years ago

(In [7918]) Resurrect comment approval notification. Props chmac. fixes #6892 for 2.5

comment:4 MtDewVirus6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This patch results in duplicate comment notification emails being sent when comments are approved by using the approve link in a moderation notification email.

MtDewVirus6 years ago

comment:5 MtDewVirus6 years ago

Patch was created on trunk r8003.

comment:6 ryan6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [8004]) Fix duplicate comment notifications. Props MtDewVirus. fixes #6892 for trunk

comment:7 ryan6 years ago

(In [8005]) Fix duplicate comment notifications. Props MtDewVirus. fixes #6892 for 2.5

comment:8 ryan6 years ago

  • Milestone changed from 2.5.2 to 2.9

Milestone 2.5.2 deleted

comment:9 westi6 years ago

  • Milestone changed from 2.9 to 2.6
Note: See TracTickets for help on using tickets.