WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#6932 closed defect (bug) (fixed)

Translation of message for protected comemnts can break comments feed

Reported by: nbachiyski Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version:
Component: Feeds Keywords: has-patch commit
Focuses: Cc:

Description

If the translation of Protected Comments: Please enter your password to view comments. contains invalid XML it will break the comments feed.

Attached is a patch, which encloses the string in CDATA, so that it can contain whatever the translators want.

Attachments (2)

comments-feed-cdata.diff (938 bytes) - added by nbachiyski 10 years ago.
6932.diff (911 bytes) - added by Denis-de-Bernardy 9 years ago.

Download all attachments as: .zip

Change History (4)

#1 @Denis-de-Bernardy
9 years ago

  • Component changed from i18n to Feeds
  • Keywords has-patch commit added; feed xdata i18n removed
  • Milestone changed from 2.9 to 2.8

Not sure this still needed, given the ent2ncr() call. But here goes...

#2 @ryan
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Looks like we use ent2ncr for this elsewhere. Marking as fixed now that ent2ncr is there.

Note: See TracTickets for help on using tickets.