WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#7967 closed enhancement (fixed)

Small cleanup in admin part CSS files

Reported by: Simek Owned by:
Milestone: 2.7 Priority: low
Severity: minor Version: 2.7
Component: Template Keywords: patch CSS
Focuses: Cc:

Description

I tried to optimize, clean and make those CSS files easily to read.

Changes tested with latest revision.

Attachments (4)

css.files.cleanup.patch (15.7 KB) - added by Simek 5 years ago.
press-this.css.patch (11.4 KB) - added by Simek 5 years ago.
"press-this.css" file cleanup with azaozz advices
media.css.patch (2.2 KB) - added by Simek 5 years ago.
rtl.css.patch (10.0 KB) - added by Simek 5 years ago.

Download all attachments as: .zip

Change History (10)

Simek5 years ago

comment:1 azaozz5 years ago

Thanks for the patch. We will need to do a lot of cleaning of all css files to remove all old/not used styles left over from 2.6 and early Crazyhorse.

One thing though: can you leave selectors with only one setting be on multiple lines, so instead of

.widefat { border-color: #dfdfdf; }

which actually is harder to read, make it:

.widefat {
    border-color: #dfdfdf;
}

using a tab to indent it.

Also when specifying one setting for multiple selectors, the preferred format is to put each selector on a new line (much easier to read) like that:

.wp_themeSkin a:link,
.wp_themeSkin a:visited,
.wp_themeSkin a:active {
	color: #000;
}

(I know there's some software that would format css files automatically.)

comment:2 Simek5 years ago

Thank you for advices azaozz. I'll prepare new patch for those files.

Simek5 years ago

"press-this.css" file cleanup with azaozz advices

comment:3 azaozz5 years ago

(In [9370]) Some CSS cleanup, props Simek, see #7967

comment:4 azaozz5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [9371]) Press This CSS cleanup, props Simek, fixes #7967

comment:5 Simek5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

New patches for:
"wp-admin\css\media.css"
"wp-admin\rtl.css"

Media.css => Cleanup, others opacity types added.
RTL.css => Cleanup, -moz-border-radius reduced to one line.

Simek5 years ago

Simek5 years ago

comment:6 azaozz5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [9383]) media.css and rtl.css cleanup, props Simek, fixes #7967

Note: See TracTickets for help on using tickets.