Save Changes Button Inconsistency on Settings Pages

[sivel]

The Permalinks and Miscellaneous settings pages have class="button" on the "Save Changes" button. General, Writing, Reading, Discussion, Media, and Privacy do not include this class.

I have attached 2 diffs. 1 to add the class (addclass.diff) and 1 to remove the class (remclass.diff) as I am not sure which one is supposed to be correct.

[sivel]

These are mutli-file diffs and don't appear to render in Trac. Download to view the diff.

[sivel]

I was just looking at some more of the pages. It looks like all other pages do not include class="button" so if the correct way is to not have class="button" then remclass.diff will work for you...Otherwise there will be additional editing required to add class="button" on all other pages with an equivalent button.

[azaozz]

Ideally all buttons would have one of the 3 button classes, .button, .button-primary (emphasis) or .button-secondary (when the button is on a coloured background). There may be also couple of 'special cases' but can deal with them when all the rest of the colours are in.

Of course the "button" element would have equivalent styling as having class="button". The same can be done for input[type="submit"] but won't work in old non-standard compliant browsers, so will have to add class="button" like your first patch.

[sivel]

Okay...updating the addclass.diff to addclass.1.diff

This new diff contains class="button" for all needed submit buttons in wp-admin excluding wp-admin/import/wordpress.php. See #7982 for fixes to wp-admin/import/wordpress.php.

[azaozz]

(In [9369]) Fix button styling inconsistency on settings pages, props sivel, fixes #7975