WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#7985 closed enhancement (fixed)

Settings pages consistency

Reported by: Speedboxer Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.7
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Many of the settings page's text fields are different sizes (due to fixed-width fonts or what have you), we should use pixel width's (and not character widths) to keep them consistently sized.

Attachments (2)

7985.diff (25.1 KB) - added by Speedboxer 6 years ago.
Make settings pages more consistent
readonly-class-textarea.diff (616 bytes) - added by Speedboxer 6 years ago.
Make readonly class work on textareas

Download all attachments as: .zip

Change History (6)

@Speedboxer6 years ago

Make settings pages more consistent

comment:1 @Speedboxer6 years ago

  • Keywords has-patch added

This patch adds classes large-text, regular-text and small-text and change the Settings pages text fields to use them. It also changes the submit buttons on Users and options.php to button-primary.

It also changes the .htaccess code on the Permalinks settings page to be readonly, which I'm hoping is okay (I don't see a reason for it to be editable). :)

comment:2 @westi6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [9390]) Move inline styles to the stylesheets. Fixes #7985 props Speedboxer.

@Speedboxer6 years ago

Make readonly class work on textareas

comment:3 @Speedboxer6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Opps, the readonly class is for inputs only, readonly-class-textarea.diff fixes that.

comment:4 @westi6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [9419]) Apply styles to readonly textareas too. Fixes #7985 props Speedboxer.

Note: See TracTickets for help on using tickets.