WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8674 closed feature request (fixed)

Support compressed streams in the HTTP API

Reported by: jacobsantos Owned by: jacobsantos
Milestone: 2.8 Priority: normal
Severity: normal Version:
Component: HTTP API Keywords: has-patch needs-testing
Focuses: Cc:

Description

Some of the transports support decompressed compressed data, while the others do not. The ticket establishes that all transports will support decompressed data that was sent over HTTP.

I think the PclZip library can be used, but it will require testing to be sure.

Attachments (2)

8674.diff (5.7 KB) - added by jacobsantos 6 years ago.
Add Gzip support to the HTTP API.
8674.2.diff (7.1 KB) - added by jacobsantos 6 years ago.
Better and complete implementation of gzip.

Download all attachments as: .zip

Change History (12)

comment:1 @DD326 years ago

Ideally PclZip() should be avoided at all costs if there is an alternate decompression function available, Simply for the fact it does everything in PHP rather than Compiled C++, and Compression functions are better optimized in such a language.

See: http://au.php.net/manual/en/function.gzuncompress.php http://au.php.net/manual/en/function.gzdecode.php

comment:2 @jacobsantos6 years ago

  • Component changed from General to HTTP

comment:3 @jacobsantos6 years ago

  • Summary changed from Support Compressed streams in the HTTP API to Support compressed streams in the HTTP API

@jacobsantos6 years ago

Add Gzip support to the HTTP API.

comment:4 @jacobsantos6 years ago

  • Keywords has-patch needs-testing added

comment:5 @jacobsantos6 years ago

The patch implements Gzip classes, but isn't used in the HTTP API anywhere.

comment:6 @jacobsantos6 years ago

  • Keywords needs-patch added; has-patch removed

Well, after thinking about and talking to DD32, a better solution would be to use one class instead. Still needs testing though.

@jacobsantos6 years ago

Better and complete implementation of gzip.

comment:7 @jacobsantos6 years ago

  • Keywords has-patch added; needs-patch removed

Patch needs testing. Need to see if the patch works for those having issues.

comment:8 @westi6 years ago

(In [10410]) First pass compression support for the HTTP API. See #8674 props jacobsantos.

comment:9 @jacobsantos6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I'm going to say that this works, since it has been tested and appears to work okay. Any problems can be patched in a new ticket.

comment:10 @Denis-de-Bernardy6 years ago

See #9761 in particular

Note: See TracTickets for help on using tickets.