WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#9344 closed defect (bug) (invalid)

Text-Widget adds spaces

Reported by: hetjens Owned by:
Milestone: Priority: high
Severity: major Version: 2.7.1
Component: Widgets Keywords: widget, text, spaces
Focuses: Cc:

Description

The Text-Widget adds spaces between $before_widget and $before_title. Theses spaces can influence the rendering of the widget in some browsers.

Other widgets don't do it.

Attachments (1)

widgets.patch (670 bytes) - added by hetjens 6 years ago.

Download all attachments as: .zip

Change History (5)

@hetjens6 years ago

comment:1 @Viper007Bond6 years ago

  • Milestone 2.7.2 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Widgets have been re-written for Wordpress 2.8 and the code is as you describe in the WP_Widget_Text class: source:trunk/wp-includes/default-widgets.php

comment:2 @hetjens6 years ago

  • Milestone set to 2.7.2
  • Resolution invalid deleted
  • Status changed from closed to reopened

Yes, I know, that the code is re-written. But the part in the class WP_Widget_Text is only copied-pasted from the old version. So the bug still exists in the current version. My patch is already for the rewritten widgets.

comment:3 @Viper007Bond6 years ago

I think you're mistaken or running an old version of trunk. Click the link I posted above. There are no spaces that I see.

echo $before_widget;
if ( !empty( $title ) ) { echo $before_title . $title . $after_title; } ?>

comment:4 @DD326 years ago

  • Milestone 2.7.2 deleted
  • Resolution set to invalid
  • Status changed from reopened to closed

Code in question doesnt exist anymore, Old code exited from the PHP block which introduced spaces, New code does not (Other than between the title and the div block)

Ticket is still invalid.

Note: See TracTickets for help on using tickets.