WordPress.org

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#994 closed defect (bug) (fixed)

Installation files not internazionalized

Reported by: SteveAgl Owned by: ryan
Milestone: Priority: normal
Severity: trivial Version: 1.5
Component: General Keywords:
Focuses: Cc:

Description

The files:
wp-admin/install.php
wp-admin/upgrade-schema.php
wp-admin/wp-settings.php

have strings out of the .POT file that doesn't use gettext function.

Same for all wp-admin/import-*.php files but in this case the text is a lot and maybe it doens't worth have them full full () and _e()

Attachments (3)

admin-i18n.diff (7.8 KB) - added by SteveAgl 13 years ago.
install-gettext.diff (4.0 KB) - added by SteveAgl 13 years ago.
install-i18n-and-email-check.diff (5.5 KB) - added by SteveAgl 13 years ago.

Download all attachments as: .zip

Change History (17)

#1 @SteveAgl
13 years ago

  • Patch set to No

#2 @ryan
13 years ago

  • Owner changed from anonymous to rboren
  • Status changed from new to assigned

#3 @nbachiyski
13 years ago

In the patch: all above without import-* functions.

edited on: 02-27-05 21:45

#7 @matt
13 years ago

I think we should hold off on the importers for now. In 1.6 those will be integrated with the admin better and will be gettexted.

#8 @SteveAgl
13 years ago

In the install.php the text at lines 188 nd 190 even if present in the .pot files, correctly impèorted into .po file and translated, are still in english. It looks like they doesn't match on gettext.

#10 @slebog
13 years ago

Added install-gettext.diff which gettexts the default database entries in install.php

8 strings need adding to the .pot

#11 @nbachiyski
13 years ago

In the install-i18n-and-email-check.diff patch:
Default post and comment texts gettexted, and e-mail validity check added to install.php.
Maybe the second issue could be filed in another report, but I had to wait for the i18n patch to be applied in order to produce the e-mail check patch.

#12 @nbachiyski
13 years ago

Ooops, I did not see the slebog's patch. Sorry.

#14 @anonymousbugger
13 years ago

The very first string in install.php is left untranslated (line 4):

die("There doesn't seem to be a <code>wp-config.php</code> file. I need this before we can get started ...

#15 @ryan
13 years ago

That string cannot be translated because wp-config.php must be loaded before we can make gettext calls. Since the error occurs in the event that wp-config.php cannot be loaded, gettext is not available.

#16 @ryan
13 years ago

  • fixed_in_version set to 1.5.1
  • Resolution changed from 10 to 20
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.