Ticket #10326 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 2 years ago

strip_shortcodes() greedily strips surrounding bytes

Reported by: markjaquith Owned by: markjaquith
Priority: high Milestone: 2.9
Component: Shortcodes Version: 2.8
Severity: critical Keywords: has-patch needs-testing
Cc:

Description

strip_shortcodes() which is run on excerpts is too greedy.

Input:

before[gallery]after

Output:

beforfter

As you can see, the characters immediately preceding and following the shortcode have been stripped out. These characters should be preserved.

Attachments

10326.001.diff Download (751 bytes) - added by markjaquith 3 years ago.

Change History

markjaquith — 3 years ago

comment:1   markjaquith — 3 years ago

  • Keywords has-patch needs-testing added
  • Owner set to markjaquith
  • Status changed from new to accepted

Patch uploaded. Return the 1st and 6th matches, like do_shortcode_tag() does. Works for me. Can I get someone to verify?

comment:3   westi — 2 years ago

  • Status changed from accepted to closed
  • Resolution set to fixed

[12206]

comment:4   westi — 2 years ago

I've added test cases for this to wordpress-tests

 http://svn.automattic.com/wordpress-tests/wp-testcase/test_shortcode.php

comment:5   miqrogroove — 2 years ago

  • Severity changed from major to critical

Increase severity because this bug is causing UTF-8 corruption and Google was rejecting my feeds until I applied this patch.

comment:6   miqrogroove — 2 years ago

  • Summary changed from strip_shortcodes() greedily strips surrounding characters to strip_shortcodes() greedily strips surrounding bytes
Note: See TracTickets for help on using tickets.