'Delete Permanently' does not ask for confirmation when trash is disabled

[sirzooro]

When Trash is disabled (EMPTY_TRASH_DAYS defined to 0), WP does not ask for confirmation when someone clicks on 'Delete Permanently' link do delete post/page (probably attachments too). This applies for links on post/page list and post/page edit screens.

See also #11183

[scribu]

This would practically defeat the whole purpose of Trash. Maybe disabling trash shouldn't be an option in the first place.

[sirzooro]

Some people (like me) prefer to directly delete instead of trashing first, so such option is useful for them. So when someone uses it, WP should revert to pre-WP2.9 behaviour and ask for confirmation, to prevent mistakes when someone will click "Delete Permanently" link by accident.

[janeforshort]

The pre-2.9 behavior of asking for confirmation first got me a ton of hate mail from people who demanded to know why I thought they weren't capable of clicking the right link. If someone prefers to delete directly, then they should just be careful of what they do. I'd rather see a confirmation prompt on every deletion in that case as a plugin instead of the other way around, since most people found the confirmation prompt to be annoying and disruptive.