Make WordPress Core

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#14199 closed defect (bug) (fixed)

wp_rss() and get_rss() break UTF-8 titles

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Feeds Keywords: has-patch
Focuses: Cc:

Description

The problem described in #10378 is also related to wp_rss() and get_rss(). They use htmlentities( $item['title'] ), which makes the title unreadable.

Though both functions have been deprecated, they still exist and therefore need to be fixed.

Attachments (1)

do-not-use-htmlentities-on-feed-titles.patch (656 bytes) - added by SergeyBiryukov 14 years ago.

Download all attachments as: .zip

Change History (4)

#1 @nacin
14 years ago

  • Milestone changed from Awaiting Review to 3.1

#2 @nacin
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16031]) Use esc_html. Ancient, deprecated functions, but a valid fix nonetheless. fixes #14199.

#3 @nacin
14 years ago

Something accidentally snuck into that commit, but it was an intentional change based on codex.wordpress.org/Inline_Documentation#.40author_Tag and the fact that none of the code that started add_option() is there anymore. So I'm going to leave it.

Note: See TracTickets for help on using tickets.