Hello Dolly can't cope with the admin bar

[nacin]

And given the choice to deactivate Hello Dolly or turn off the admin bar, I had no choice but to turn off the admin bar.

Screenshot attached.

[nacin]

Not looking so swell here :-(

[kapeels]

Added jQuery code to check the location of #wp-head and to change the position of #dolly accordingly.

Patch - hello.diff

PS - This is my first patch. Please point mistakes. Thanks.

[sbressler]

This is just about the most amusing bug I have seen :)

Using JS to position the text is too heavy-weight for a plugin that's meant to showcase the simplicity of writing a plugin. Absolute position in general is lackluster. Either remove the positioning and just attach the output to an appropriate admin filter or explicitly check for the existence of the admin bar.

[kapeels]

Okay. So here's a new one, this uses admin_notices action and works good. But there doesn't seems to be a documentation for admin_notices. Could anybody add that?

Attaching hello.diff

[kapeels]

Patch.

[nacin]

This looks good.

[nacin]

(In [16270]) Hello Dolly 1.6. fixes typo, props sbressler, fixes #15229. Removes absolute from positioning, props kapeels, fixes #15228. Add some whitespace.

[nacin]

admin_notices is only for the blog admin. We'll need to use all_admin_notices here.

That's annoying however, as linking both will mean that you'll get it twice, and adding all three (network, user) doesn't scale if we ever come up with a fourth. I've proposed a change to the functionality in #14696. If that goes through, this can be re-closed as fixed.

[nacin]

[16292]

[kapeels]

@nacin Does that really mean I fixed my first bug in WordPress? :D

As @sbressler said, this plugin showcases simplicity of writing a plugin. I feel there should be some codex docs for the actions.

[nacin]

Replying to kapeels:

@nacin Does that really mean I fixed my first bug in WordPress? :D

Yes! Congratulations. :)

As @sbressler said, this plugin showcases simplicity of writing a plugin. I feel there should be some codex docs for the actions.

It would be cool to eventually add some more inline documentation and comments, a la Twenty Ten.

[SergeyBiryukov]

Replying to kapeels:

But there doesn't seems to be a documentation for admin_notices. Could anybody add that?

​http://codex.wordpress.org/Plugin_API/Action_Reference/admin_notices