WordPress.org

Make WordPress Core

Opened 21 months ago

Closed 17 months ago

Last modified 17 months ago

#18770 closed defect (bug) (fixed)

Make repair.php fully translatable

Reported by: ocean90 Owned by: ryan
Priority: low Milestone: 3.4
Component: I18N Version: 3.3
Severity: minor Keywords: has-patch
Cc:

Description


Attachments (3)

18770.patch​ (3.7 KB) - added by ocean90 21 months ago.
18770.2.patch​ (861 bytes) - added by ocean90 20 months ago.
18770-zeo.diff​ (6.6 KB) - added by Zeo 19 months ago.
repair.php l10n tweak and more

Download all attachments as: .zip

Change History (15)

ocean90 — 21 months ago

comment:1 ocean90 — 21 months ago

  • Version set to 2.9

comment:2 ryan — 20 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19070]:

Make repair.php fully translatable. Props ocean90. fixes #18770

comment:3 ocean90 — 20 months ago

18770.2.patch will fix my placeholder fail. Sry.

ocean90 — 20 months ago

comment:4 ryan — 20 months ago

In [19073]:

gettext fix. Props ocean90. fixes #18770

comment:5 Zeo — 19 months ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version 2.9 deleted

Sorry for re-opening this ticket.

In my patch:

  • Add missing paragraph
  • Add missing semicolon (what's up with the non-breaking space galore)
  • Make support forum URL translatable
  • Unnecessary double spacing in strings

comment:6 ryan — 19 months ago

  • Milestone changed from 3.3 to Future Release

We limit use of get_option() in repair.php because repair.php is usually visited when there is a problem with the options table.

Zeo — 19 months ago

repair.php l10n tweak and more

comment:7 Zeo — 19 months ago

@ryan patch refresh.

comment:8 SergeyBiryukov — 19 months ago

18770-zeo.diff​ seems good for 3.3? Only strings/markup fixes. At least "Make support forum URL translatable" part would be nice.

comment:9 Zeo — 19 months ago

@SergeyBiryukov true that. Since it's not string freeze yet and there's a lot of string changes activity in #19020.

comment:10 ocean90 — 18 months ago

  • Keywords dev-feedback removed
  • Milestone changed from Future Release to 3.4
  • Version set to 3.3

comment:11 nacin — 17 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [19757]:

Formatting and i18n cleanup of repair.php. props zeo for initial patch. fixes #18770.

comment:12 nacin — 17 months ago

I think I caught everything at this point.

Note: See TracTickets for help on using tickets.