Ticket #18770 (closed defect (bug): fixed)

Opened 5 months ago

Last modified 4 weeks ago

Make repair.php fully translatable

Reported by: ocean90 Owned by: ryan
Priority: low Milestone: 3.4
Component: I18N Version: 3.3
Severity: minor Keywords: has-patch
Cc:

Description


Attachments

18770.patch Download (3.7 KB) - added by ocean90 5 months ago.
18770.2.patch Download (861 bytes) - added by ocean90 4 months ago.
18770-zeo.diff Download (6.6 KB) - added by Zeo 3 months ago.
repair.php l10n tweak and more

Change History

ocean90 — 5 months ago

comment:1   ocean90 — 5 months ago

  • Version set to 2.9

comment:2   ryan — 4 months ago

  • Owner set to ryan
  • Status changed from new to closed
  • Resolution set to fixed

In [19070]:

Make repair.php fully translatable. Props ocean90. fixes #18770

comment:3   ocean90 — 4 months ago

18770.2.patch will fix my placeholder fail. Sry.

ocean90 — 4 months ago

comment:4   ryan — 4 months ago

In [19073]:

gettext fix. Props ocean90. fixes #18770

comment:5   Zeo — 3 months ago

  • Keywords dev-feedback added
  • Status changed from closed to reopened
  • Version 2.9 deleted
  • Resolution fixed deleted

Sorry for re-opening this ticket.

In my patch:

  • Add missing paragraph
  • Add missing semicolon (what's up with the non-breaking space galore)
  • Make support forum URL translatable
  • Unnecessary double spacing in strings

comment:6   ryan — 3 months ago

  • Milestone changed from 3.3 to Future Release

We limit use of get_option() in repair.php because repair.php is usually visited when there is a problem with the options table.

Zeo — 3 months ago

repair.php l10n tweak and more

comment:7   Zeo — 3 months ago

@ryan patch refresh.

comment:8   SergeyBiryukov — 3 months ago

18770-zeo.diff Download seems good for 3.3? Only strings/markup fixes. At least "Make support forum URL translatable" part would be nice.

comment:9   Zeo — 3 months ago

@SergeyBiryukov true that. Since it's not string freeze yet and there's a lot of string changes activity in #19020.

comment:10   ocean90 — 6 weeks ago

  • Keywords dev-feedback removed
  • Version set to 3.3
  • Milestone changed from Future Release to 3.4

comment:11   nacin — 4 weeks ago

  • Status changed from reopened to closed
  • Resolution set to fixed

In [19757]:

Formatting and i18n cleanup of repair.php. props zeo for initial patch. fixes #18770.

comment:12   nacin — 4 weeks ago

I think I caught everything at this point.

Note: See TracTickets for help on using tickets.