Opened 13 months ago

Closed 8 months ago

#20533 closed enhancement (fixed)

Move WP_Embed class to class-wp-embed.php

Reported by: ocean90 Owned by: nacin
Priority: normal Milestone: 3.5
Component: Embeds Version:
Severity: normal Keywords: has-patch
Cc: kpayne@…

Description

The current place is wp-includes/media.php.

Attachments (1)

20533.patch​ (19.0 KB) - added by ocean90 13 months ago.

Download all attachments as: .zip

Change History (4)

ocean90 — 13 months ago

comment:1   ocean90 — 10 months ago

  • Milestone changed from Future Release to 3.5

comment:2   kurtpayne — 10 months ago

  • Cc kpayne@… added

So the memory miser in me says: WP_Embed is referenced in ajax-actions.php and media.php. It should only be require'd in those files.

But the back compat guy in me says: Removing a global variable / class will break plugins and themes.

This change seems innocuous ... is it just for organization?

comment:3   nacin — 8 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21999]:

Move WP_Embed into its own file. props ocean90. fixes #20533.

Note: See TracTickets for help on using tickets.