Opened 9 months ago

Closed 9 months ago

#21590 closed defect (bug) (fixed)

Adding a link category through the add link screen is broken

Reported by: yoavf Owned by: markjaquith
Priority: normal Milestone: 3.4.2
Component: Administration Version:
Severity: normal Keywords: has-patch
Cc: yoavf

Description

Broken since r21205

Attachments (1)

link-category.diff​ (1.5 KB) - added by yoavf 9 months ago.

Download all attachments as: .zip

Change History (10)

yoavf — 9 months ago

comment:1   SergeyBiryukov — 9 months ago

  • Keywords has-patch added
  • Owner has-patch deleted
  • Status changed from new to assigned

comment:2   yoavf — 9 months ago

  • Cc yoavf added

comment:3   yoavf — 9 months ago

Owner: has-patch

I need more coffee... :)

comment:4   helenyhou — 9 months ago

Related: #21152 (may affect what's going on here, not sure)

yoavf - do you mind explaining why that patch works? I don't really understand from looking at it :)

comment:5   yoavf — 9 months ago

The patch work by assigning the proper expected ID to the input, the id that will be expected following the changeset in r21205 (the target was previously a class, and the ID was not in the proper format)

comment:6   nacin — 9 months ago

  • Milestone changed from 3.5 to 3.4.2

comment:7   markjaquith — 9 months ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from assigned to closed

In [21688]:

Fix the adding of link categories through the "Add Link" screen. props yoavf. fixes #21590 for trunk

comment:8   markjaquith — 9 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-open for 3.4.2

comment:9   nacin — 9 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [21717]:

Merge [21205] and [21688] to the 3.4 branch. props SergeyBiryukov, yoavf. fixes #21590. see #21106.

Note: See TracTickets for help on using tickets.