Custom Field "Update" button failure

[BaronHigbee]

I have done my best to search and test and the "Update" button located in all Custom Fields is not functioning with the latest update of the WordPress core. The button vanishes when pressed and does not update the Custom Field.

Additionally it creates a "button artifact" at the bottom of the Custom Field list that looks like another "update" button and even functions like one, but still does nothing.

I have tested it on multiple computers and multiple browsers. All PCs with FF, Safari, Chrome, IE, and Opera.

I have also tested with separate servers and websites with the same result. I've done my best to fix it, but I can't find the problem.

THIS IS A BUG FOR VERSION 3.4.2 - which is not yet listed on Trac

[BaronHigbee]

Image of the problem

[sethta]

I have also noticed this same issue as of 3.4.2. I have tested and confirmed it on three separate sites, checking before the upgrade where it works, and after where it doesn't.

It is only possible to update custom fields through changing the value in the editor and then clicking Save Draft/Publish/Update.

In addition the the update button not working, the Add Custom Field button does the exact same thing where it becomes a "button artifact", meaning that no new custom fields can be added through the Custom Fields meta box.

[sethta]

Image of Add Custom Field "button artifact"

[SergeyBiryukov]

Broken in [21205] :(

[SergeyBiryukov]

Currently, multiple Update buttons have the same ID (#updatemeta).

21829.patch​ fixes that as well.

[BaronHigbee]

Attempted the patching but the problems remained

[BaronHigbee]

Also plz note - the final code change was for wp-lists.dev.js NOT for wp-lists.js

[garscott]

I applied the patch and the update button and add custom field works on 3.4.2. Thanks.

[c3mdigital]

Patch tested against 3.4.2 and r21780. Fixes broken update and add custom field button.

[SergeyBiryukov]

Replying to BaronHigbee:

Also plz note - the final code change was for wp-lists.dev.js NOT for wp-lists.js

The patch is for current trunk (​http://wordpress.org/download/svn/).

To test on 3.4.2:

1. Apply the same change to wp-lists.dev.js.
2. Add this line to your wp-config.php file:

   define('SCRIPT_DEBUG', true);
   

   ​http://codex.wordpress.org/Debugging_in_WordPress#SCRIPT_DEBUG

[ocean90]

[21717] for the 3.4 branch.

[ocean90]

Patch for the 3.4 branch.

[nacin]

Pretty incredible this was broken for two months in trunk.

This looks like Hotfix material. But... I also understand how often users use Custom Fields (to the partially understandable chagrin of developers everywhere). So let's put something together for Hotfix if possible (be creative) and then look to see if a 3.4.3 is needed due to demand.

[SergeyBiryukov]

Replying to nacin:

So let's put something together for Hotfix if possible (be creative)

fix-custom-fields-in-wp342.php​ is a hacky workaround I've been testing.

[BaronHigbee]

@Sergey yep that was my WP dev noob mistake... patch applied and script_debug set to true. Patch works and all is functioning :)

[nacin]

Going to release Hotfix shortly.

​http://plugins.trac.wordpress.org/changeset/595967/hotfix
​http://plugins.trac.wordpress.org/changeset/595980/hotfix

Let's also have something working in trunk. 21829.patch​?

[nacin]

In [21781]:

Fix adding and updating from the Custom Fields meta box. Broken in [21205]. props SergeyBiryukov. see #21829 for trunk.

[nacin]

Let's make sure [21781] works for all uses of wp-lists.

Looks like neither admin-categories nor admin-custom-fields are even used anymore. Still, it's listed as a dependency on edit-comments.js, post.js, link.js, and nav-menu.js.

[nacin]

Hotfix 0.9 is now out, and will fix these issues with WordPress 3.4.2: ​http://wordpress.org/extend/plugins/hotfix/. (​http://plugins.trac.wordpress.org/changeset/596040)

Once we can confirm [21781] is a complete fix with no lingering bugs, we can port that to the 3.4 branch. No timeline or current plans for 3.4.3.

[Amit_k]

update custom field button (mess)

[Asif2BD]

Replying to nacin:

Hotfix 0.9 is now out, and will fix these issues with WordPress 3.4.2: ​http://wordpress.org/extend/plugins/hotfix/. (​http://plugins.trac.wordpress.org/changeset/596040)

Once we can confirm [21781] is a complete fix with no lingering bugs, we can port that to the 3.4 branch. No timeline or current plans for 3.4.3.

So planing to release directly 3.5? no quick 3.4.3?

[nacin]

While there may be a 3.4.3, I don't think there will be a quick one. I haven't been notified of many reports in the support forums, and anyone who is having trouble has been pointed to Hotfix.

[peterjanes]

Neither the patch (which I applied to the .dev files and manually applied to the non-.devs) nor the Hotfix plugin solves the issue for me. I've found that both add and update will work with this change to Hotfix, though:

-		$('#postcustomstuff').on('hover focus', '#addmetasub, #updatemeta', function() {
+		$('#postcustomstuff').on('hover focus', '#newmeta-submit, .updatemeta', function() {

[nacin]

#newmeta-submit was added in 3.5.

[peterjanes]

That would explain why the hotfix for 3.4.2 doesn't work, then. If not a 3.4.3 release of WordPress, then perhaps a 0.9.1 for the plugin?

[nacin]

Replying to peterjanes:

That would explain why the hotfix for 3.4.2 doesn't work, then. If not a 3.4.3 release of WordPress, then perhaps a 0.9.1 for the plugin?

Hotfix works fine for me with 3.4.2. My point was that #newmeta-submit is not present in 3.4.2, so changing the selector from #addmetasub to #newmeta-submit likely means one of two things:

• You've modified your WordPress install, perhaps by applying a patch from above (or are running an early version of 3.5)
• Simply removing #addmetasub (and not replacing it with #newmeta-submit) fixes it for you

[peterjanes]

Please note that the hotfix plugin has been marked by several people as not working in 3.4.2 (as many as say it does work).

I make it a practice to never modify the WordPress core and only use plugins to affect functionality, but you seem certain so I'll investigate further.

[SergeyBiryukov]

Replying to peterjanes:

Please note that the hotfix plugin has been marked by several people as not working in 3.4.2 (as many as say it does work).

If you refer to "3 people say it's broken" on the plugin page, there's not enough details to know what exactly doesn't work for them.

From what I've seen on the support forums so far, Hotfix 0.9 solves the issue with custom fields in 3.4.2. Your report is the first one indicating otherwise, so more details would be great.

[nacin]

Only other report I've seen is ​https://twitter.com/blogconsulting/status/246270155632570369.

[peterjanes]

Aha, 3.4.2's template.php update wasn't propagated by my source control system (another reason why I'm converting to git soon). Works fine now; apologies for the bugspam.

[Asif2BD]

I updated one of my site over WPEngine, instantly got custom field issue, installed Hotfix, did not solved the issue, now dont have the custom field button disappear issue, but Custom field is not saving at all.

I have used the fix-custom-fields-in-wp342 fix too, no solution so far.

[wycks]

I am surprised this did not get more attention/omgBBQ in support and on the web in general.

I can confirm that Hotfix 0.9 does work with WordPress 3.4.2

[tar.gz]

Not sure if this is related, but I notice that in WP 3.5-beta1 [22150] the custom fields are "half broken" - the Ajax is not working, adding or updating a custom field reloads the whole page. Tested in FF16 and chrome 21 (osx).

[SergeyBiryukov]

Replying to tar.gz:

in WP 3.5-beta1 [22150] the custom fields are "half broken" - the Ajax is not working, adding or updating a custom field reloads the whole page.

AJAX is broken due to some changes in #21598. #21852 was an attempt to fix that, but the consensus was to focus on #21152 instead.

[tahrirsquare]

The hotfix plugin does not work any more with Wordpress 3.4.2. It worked fine until I updated PHP to 5.4.7 from 5.3.17. Now, when creating a new custom field it lands in a big pink box with red border, right above the existing custom fields, and in order to create another custom field the post must be updated/saved just like before.

See attached image below.

UPDATE: Disregard my comment. Hotfix works, see my comment below.

[tahrirsquare]

Custom fields bug

[tahrirsquare]

Disregard my comments. I apologize for the false alarm. The error was caused due to wp-config.php had a UTF-8 encoding. Changing to UTF-8 without BOM fixed it.

[SergeyBiryukov]

Updated 21829.34-branch.patch​ to include the fix for link categories from #22340.

[nacin]

In 22371:

Fix ajax adding of custom fields and link categories. props SergeyBiryukov. for the 3.4 branch. see #21829.

[SergeyBiryukov]

#22391 was marked as a duplicate.

[PhilipVictor]

Hello,
After I made the update from wordpress 3.2.0 to wordpress 4.0 I found a problem with Custom Field it appears as html code ( I mean when I write inside the custom field I have to write as a html not as a normal text)

[SergeyBiryukov]

Replying to PhilipVictor:

After I made the update from wordpress 3.2.0 to wordpress 4.0 I found a problem with Custom Field

This ticket was closed on a completed milestone, please create a new one.