Opened 8 months ago

Closed 7 months ago

#22018 closed defect (bug) (fixed)

Unexpected "Save Changes" button in "old" media uploader

Reported by: TobiasBg Owned by: nacin
Priority: normal Milestone: 3.5
Component: UI Version: 3.5
Severity: normal Keywords: has-patch commit
Cc:

Description

When clicking on the "Insert/Upload" button (next to the new/temporary "Beta Media" button) on any post edit screen, I have a "Save Changes" button right above the "Add media files from your computer" heading on the "From Computer" tab, that has not been there in WP 3.4.2, and that doesn't really make sense until something was uploaded.

Attachments (1)

22018.diff​ (472 bytes) - added by helenyhou 7 months ago.

Download all attachments as: .zip

Change History (7)

comment:1   TobiasBg — 8 months ago

Further investigation: The button (coming from here) does have a class "hidden", so likely some CSS that should actually hide the button is gone.

comment:2   SergeyBiryukov — 8 months ago

  • Component changed from General to Media
  • Milestone changed from Awaiting Review to 3.5

helenyhou — 7 months ago

comment:3   helenyhou — 7 months ago

  • Component changed from Media to UI
  • Keywords has-patch added

.button has display: inline-block, which is overriding the display: none for .hidden. Not sure what the best thing to do is - .button.hidden maybe? 22018.diff​ for that.

comment:4   sabreuse — 7 months ago

Patch works for me

comment:5   lessbloat — 7 months ago

  • Keywords commit added

+1 to 22018.diff.

comment:6   nacin — 7 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22440:

Allow the .hidden class to hide a button. props helenyhou. fixes #22018.

Note: See TracTickets for help on using tickets.