Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#22583 closed defect (bug) (fixed)

Let dragging work in IE10 via touch interface.

Reported by: georgestephanis's profile georgestephanis Owned by: ryan's profile ryan
Milestone: 3.5 Priority: normal
Severity: major Version: 3.5
Component: UI Keywords: has-patch commit
Focuses: Cc:

Description (last modified by georgestephanis)

In testing on the Microsoft Surface RT tablet, draggable things were completely undraggable through the touch interface -- whether they were dashboard boxes, widgets, or menu items.

As per http://msdn.microsoft.com/en-us/library/windows/apps/hh767313.aspx and https://msmvps.com/blogs/theproblemsolver/archive/2012/10/24/jquery-ui-and-windows-8-and-internet-explorer-10-touch-screens.aspx this can be solved quite simply by adding the -ms-touch-action: none; property to the CSS of the elements in question.

If someone would prefer to do it via Javascript, it can be done via

if (typeof el.style.msTouchAction != 'undefined') el.style.msTouchAction = "none";

but I'm happy just doing it via CSS for the moment unless Koop would prefer it be in the js.

Attachments (4)

22583.diff (1.7 KB) - added by georgestephanis 11 years ago.
22583.2.diff (473 bytes) - added by georgestephanis 11 years ago.
22583.3.diff (474 bytes) - added by georgestephanis 11 years ago.
22583.4.diff (908 bytes) - added by koopersmith 11 years ago.

Download all attachments as: .zip

Change History (11)

#1 @georgestephanis
11 years ago

  • Description modified (diff)

#2 @koopersmith
11 years ago

As per a discussion in IRC, we're going to go with a broad, CSS-based fix that targets jQuery UI until a fix is rolled into jQuery UI core.

#3 @georgestephanis
11 years ago

22583.2.diff as per koop

#4 @nacin
11 years ago

  • Milestone changed from Awaiting Review to 3.5

#5 @koopersmith
11 years ago

I have no means of testing this, but this looks solid. We'll also need to drop this snippet at the beginning of media-views.css.

@koopersmith
11 years ago

#6 @koopersmith
11 years ago

  • Keywords commit added

Added. Based on our IRC conversation earlier and georgestephanis testing as he developed the patch, this is ready. Let's rock.

#7 @ryan
11 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 22866:

Fix dragging in IE10 on touch devices.

Props georgestephanis, koopersmith
fixes #22583

Note: See TracTickets for help on using tickets.