#22584 closed defect (bug) (worksforme)
Typo: Missing blank
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Administration | Version: | |
| Severity: | trivial | Keywords: | |
| Cc: |
Description
After running an update I receive the message "… updated successfully. Show DetailsHide Details." with a missing blank in "DetailsHide".
http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-upgrader.php#L1236
is
$this->upgrader->strings['skin_update_successful'] = __('%1$s updated successfully.').' <a onclick="%2$s" href="#" class="hide-if-no-js"><span>'.__('Show Details').'</span><span class="hidden">'.__('Hide Details').'</span>.</a>';
but should be
$this->upgrader->strings['skin_update_successful'] = __('%1$s updated successfully.').' <a onclick="%2$s" href="#" class="hide-if-no-js"><span>'.__('Show Details').'</span> <span class="hidden">'.__('Hide Details').'</span>.</a>';
Attachments (4)
Change History (15)
comment:1
follow-up:
↓ 2
ocean90
— 7 months ago
- Keywords close added
They shouldn't be displayed together. Seems like the CSS file wasn't loaded here.
comment:2
in reply to:
↑ 1
miqrogroove
— 7 months ago
Replying to ocean90:
They shouldn't be displayed together. Seems like the CSS file wasn't loaded here.
Also that line hasn't changed in the trunk version since 3.4.2. What are the steps to reproduce this issue?
comment:3
follow-up:
↓ 4
markoheijnen
— 7 months ago
I'm curious which CSS wasn't loaded then. Can't see anything for that. Also weird to do that spacing with CSS instead of a space
comment:4
in reply to:
↑ 3
ocean90
— 7 months ago
Replying to markoheijnen:
I'm curious which CSS wasn't loaded then.
Must be wp-admin.css, since the color exists, which is defined in color-*.css. Have in mind, that it's an iframe request.
How it does look for me: http://cl.ly/L7OX and http://cl.ly/L74e
comment:5
miqrogroove
— 7 months ago
I've attempted to reproduce this on 3.4.2 and on 3.5-RC1. In both, I never get output beyond "Downloading update from http://wordpress.org/extend/themes/download/twentyeleven.1.4.zip…" Is this another bug?
comment:6
miqrogroove
— 7 months ago
Never mind previous comment. I just noticed from the original screen shot that this is happening on the Updates page, not on the Themes page, which seems to have totally different output.
comment:7
miqrogroove
— 7 months ago
In miqro-screen-shot.png you can see that the second link is not supposed to be displayed as it was in screenshot.jpg.
comment:8
miqrogroove
— 7 months ago
See also miqro-show-details.png. Unable to reproduce this bug in RC1 so far.
comment:9
pixolin
— 7 months ago
- Resolution set to worksforme
- Status changed from new to closed
I am sorry! It turns out I had an older beta version installed. Should pay more attention next time.
comment:10
helenyhou
— 7 months ago
- Keywords close removed
- Milestone Awaiting Review deleted
- Version trunk deleted
comment:11
SergeyBiryukov
— 7 months ago
- Component changed from General to Administration
Screenshot of the message with the missing link.