Opened 6 months ago

Closed 6 months ago

#22594 closed defect (bug) (fixed)

Media: Rename 'id' to 'state' in menu item view

Reported by: koopersmith Owned by: ryan
Priority: normal Milestone: 3.5
Component: Media Version: 3.5
Severity: normal Keywords: has-patch commit
Cc:

Description

The MenuItem view leverages an id that is tied to the state that it will activate. However, a view's id is also tied to the id attribute on the element it creates, and we don't want to set that attribute, as multiple instances of media can exist on a page.

Attachments (1)

22594.diff​ (943 bytes) - added by koopersmith 6 months ago.

Download all attachments as: .zip

Change History (4)

comment:1   koopersmith — 6 months ago

  • Keywords has-patch added

koopersmith — 6 months ago

comment:2   nacin — 6 months ago

  • Keywords commit added

comment:3   ryan — 6 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 22851:

Rename 'id' to 'state' in menu item view.

Props koopersmith
fixes #22594

Note: See TracTickets for help on using tickets.