#22595 closed defect (bug) (worksforme)
iPad Image Un-Select Alternates Between 1 and 2 Taps
Reported by: | miqrogroove | Owned by: | |
---|---|---|---|
Milestone: | Priority: | low | |
Severity: | minor | Version: | 3.5 |
Component: | Media | Keywords: | needs-testing has-patch |
Focuses: | Cc: |
Description
Steps to reproduce:
- Open the new media modal.
- Go to the Media Library tab.
- Select (tap) an image.
- Un-select the image by tapping on the blue check mark.
Expected Result:
Image selection removed.
Actual Result:
Every-other attempt is successful on first tap. Otherwise, a second tap is required.
Attachments (2)
Change History (14)
#2
@
11 years ago
Ah. This is due to the hover state attempting to kick in before the click event. We should probably just disable the hover state on mobile devices.
#4
@
11 years ago
- Keywords needs-testing needs-patch added
- Priority changed from normal to low
Haven't been able to find a way to consistently disable or override the hover event on iOS. Patches and documentation of other OS behavior welcome.
#5
@
11 years ago
Generally touchstart
works better than click
in iOS Safari and if cancelled prevents the fake 'click` event from firing. Perhaps we can use that, not for Android though. Will look into it this afternoon.
#6
@
11 years ago
22595.patch fixes this for iOS6 Safari. It uses 'touchstart' instead of 'click' to select, deselect and remove from selection. Only tested on iPad but should work the same on all other iOS6.
#8
@
11 years ago
mobile-events-test.html is a small test of mouse events for touchscreen devices/browsers.
Results for iOS Safari:
touchstart touchend mouseover mousedown mouseup click ------------------ touchstart (prevented) touchend ------------------ touchstart touchend (prevented) ------------------
and for Android 2.1 (Kindle Fire 1)
touchstart touchend mouseover mousedown mouseup click ------------------ touchstart (prevented) touchend ------------------ touchstart touchend (prevented) mouseover mousedown mouseup click ------------------
Preventing default for touchstart
cancels the emulated mouse events in both, preventing it for touchend
cancels them in iOS but not in Android 2.1. Would be good to see what happens in Android 4 :)
Looking at the ticket further: the unselecting of images/attachments by touching the checkmark seems to work properly in iOS Safari now. We probably can attach it to both touchstart
and click
, and cancel both.
#9
@
11 years ago
- Milestone 3.5 deleted
- Resolution set to worksforme
- Status changed from new to closed
Closing as worksforme for now. If this still persists, can reopen and add 'touchstart' event there too.
#10
@
11 years ago
As discussed in IRC. If this is still occurring, please reopen this ticket.
Additionally: with multiple images selected, tapping on the grey check marks on various images has seemingly random results.