Opened 11 years ago
Closed 11 years ago
#24547 closed defect (bug) (fixed)
"Go to All %s" string not ready for i18n
Reported by: | xibe | Owned by: | azaozz |
---|---|---|---|
Milestone: | 3.6 | Priority: | high |
Severity: | major | Version: | 3.6 |
Component: | I18N | Keywords: | 2nd-opinion |
Focuses: | Cc: |
Description
The "Go to All %s" string (location is marked with %s being any post type: "Posts, Pages, etc.".
As it is, translators cannot do a direct translation of it: as with any "any post type"-related string, it should be known that depending on the language, some post types can have a "gender", and therefore cannot use the same sentence structure.
For instance, in French, Post is Article, which is masculine, when Page is Page, which is feminine. Translation for this string would then either be "Aller à tous les articles" or "Aller à toutes les pages".
Either the string is reworked, or translators should be advised to use a sentence structure that works for any content type.
Attachments (2)
Change History (7)
#1
@
11 years ago
- Milestone changed from Awaiting Review to 3.6
- Priority changed from normal to high
- Severity changed from normal to major
#3
@
11 years ago
Alternatively can more the "Go to" part before the button where "Go" can be "Navigate" or "Move", etc.
In the plugin attached to #18515 the same button is called GET ME OUT :)
Other ideas/suggestions?
#4
@
11 years ago
Introduced in [24408].
Yes, we should avoid post type and taxonomy names in generic strings, as noted in ticket:17609:3 and ticket:19099:1.
24547.patch looks good to me.
One way to fix this would be to drop the "Go to" part and use
get_post_type_object( $post->post_type )->labels->all_items;
. The button will have exactly the same action and label as the menu.