First nav menu automatically adds all pages (including sub pages) but doesn't preserve page hierarchy

[jamescollins]

When you first visit /wp-admin/nav-menus.php in WordPress 3.6, if you don't already have a menu defined it automatically creates a new menu with all published pages in the menu.

On sites with many published pages and particularly sites with multiple levels of pages (child/parent pages), all of those pages are added as top level nav menu items.

(After the first menu is created, subsequent new menu requests create empty menus with no menu items in them).

The functionality was introduced in [23441].

Previous versions (such as 3.5) didn't automatically create a new menu.

Instead, when the first nav menu is automatically created I think we should either:

1. only add all top level pages by default, or
2. add all pages (including sub pages) but preserve the page hierarchy into the nav menu.

My preference would be option 1.

[jamescollins]

25122.diff implements suggestion 1 - only top level published pages are automatically added when creating the first nav menu.

[nacin]

#page-all > ul > li > label > input[type="checkbox"] looks pretty fragile.

[jamescollins]

25122.2.diff​ now uses a slightly less fragile selector:

#pagechecklist > li > label > input[type="checkbox"]

The child selector seems to be the easiest way to only select the top level pages, however I'm open to suggestions if anyone can think of a better way of achieving the same thing.

[nacin]

Fine with this. Asked lessbloat to look.

[lessbloat]

Replying to jamescollins:

#pagechecklist > li > label > input[type="checkbox"]

Yep, this will work.

25122.3.diff​ is another approach that's perhaps slightly less fragile.

[SergeyBiryukov]

In 25122.3.diff​, parents() can probably be replaced with closest(), since it turns out to be faster (per the ​IRC discussion for #25112).

[lessbloat]

25122.4.diff​ uses closest() instead of parents().

[nacin]

In 25622:

Only show top-level items when adding pages to a User's First Nav Menu. (This is also the title of Dave's first children's book.)

props lessbloat.
fixes #25122.

[ocean90]

Related: #25445

[ocean90]

In 25687:

Revert [25622]. fixes #25445. see #25122.

[ocean90]

This needs a new patch.

[lessbloat]

Hey @ocean90,

Can you provide some additional context behind the revert? What about this patch didn't work?

[helen]

Replying to lessbloat:

Can you provide some additional context behind the revert? What about this patch didn't work?

The Ajax issue as described in #25445.