Ticket #5899 (closed enhancement: wontfix)

Opened 4 years ago

Last modified 10 months ago

New action -hook for edit.php for plugin authors to create a title

Reported by: nerrad Owned by: westi
Priority: normal Milestone:
Component: Editor Version: 2.5
Severity: normal Keywords:
Cc:

Description

For plugin authors hooking into the Manage->posts page it would be nice to be able to create a $h2_[new_title]. (see attached suggestion)

Attachments

edit-h2-action-hook.txt Download (386 bytes) - added by nerrad 4 years ago.
Suggested code for implementation
edit.php.diff Download (1.2 KB) - added by nerrad 4 years ago.
Patch for edit.php (plugin hooks for title)
edit.php.2.diff Download (1.2 KB) - added by nerrad 4 years ago.
Correction so literal string is not a variable. Translation is executed prior to filtering.

Change History

nerrad4 years ago

Suggested code for implementation

  • Milestone set to 2.6

Please create a patch.

Patch added - any chance of this getting into 2.5? It's just a small change.... (crosses fingers)

  • Keywords has-patch added; hook removed

comment:4   ryan4 years ago

Filtering the string before translation could break translations. Literal strings, not variables, must be passed to _c().

I've tested it and providing the plugin author hooks in correctly it won't break existing translations.

comment:6   ryan4 years ago

The patch does not mark the literal string for translation thus that string will not be in the POT file.

I'm still confused then, why the existing patch tests successfully with different language files loaded in WP (even after testing with a plugin using the new filter hooks).

Are you saying that automatically generated .pot files will miss this string with the patch (although existing .mo's will work as expected)? Please forgive my lack of knowledge here. Hopefully at least this is a good idea that just needs more work :)

Dang it...just noticed the error I made in the code - it's not the patch I tested lol. Uploading new patch now for eval.

nerrad4 years ago

Patch for edit.php (plugin hooks for title)

comment:9   ryan4 years ago

_c( $h2_result_reorder )

This will result in the literal string '$h2_result_order' being placed in the message catalog rather than the actual string we want to be translated. You can only filter a string after it has been translated.

nerrad4 years ago

Correction so literal string is not a variable. Translation is executed prior to filtering.

Thanks for the explanation - confirmed what I thought your were meaning but what I still didn't fully understand. Now I do. So, I've translated the string right in the apply_filters call (see new patch/diff). This should work, BUT it will require docs to indicate to plugin authors using this hook that they need to run the translation on the string before returning it. Make sense?

  • Keywords edit.php, added; edit, removed
  • Keywords manageposts action-hook filter-hook needs-testing added; manageposts, edit.php, plugin, action hook, filter hook, removed
  • Owner changed from anonymous to westi
  • Status changed from new to assigned
  • Severity changed from major to normal
  • Keywords needs-patch added; has-patch needs-testing removed
  • Component changed from Administration to Editor
  • Milestone changed from 2.9 to Future Release
  • Keywords manageposts action-hook filter-hook needs-patch removed
  • Status changed from accepted to closed
  • Resolution set to wontfix

This is quite ancient. There is no longer any <h2> in the posts-filter form.

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.