Make dead_db()'s terse message more useful

[pishmishy]

I'm not sure why a terse output was desired from dead_db. The terse message isn't particularly helpful unless you know what problems can occur when trying to establish a database connection.

Attached patch removes the terse unfriendly message and uses wp_die() in all cases.

[pishmishy]

(As a useful note, #3471 gives some related background)

[Nazgul]

I think the terse output is there to prevent potentially leaking connection info to visitors when the DB server is down.

[pishmishy]

The message output by wp_die() discloses the same information as the terse message.

[ryan]

We also don't want WP branded messages. If a site is down, that message shows up in all kinds of places with our name on it.

[westi]

No the $wpdb->error message has the db host in it

-1 to the current patch.

With regard to #3471 - are we not returning the correct headers any more?

[pishmishy]

Doesn't appear to be branded in my version. The only mentions of WordPress are in the page's title, which can be fixed, and a link to the support forums.

[pishmishy]

#3471 has nothing to do with this particular problem - just wanted to mention it as a note for myself.

I could replace the message passed to wp_die() if that's the only problem so far :-)

[Nazgul]

Replying to pishmishy:

I could replace the message passed to wp_die() if that's the only problem so far :-)

Not the only one so far. ryan also noted this one:

We also don't want WP branded messages. If a site is down, that message shows up in all kinds of places with our name on it.

[pishmishy]

Replying to Nazgul:

Not the only one so far. ryan also noted this one:

I think I addressed that one. We could remove the link to the forums if it's felt necessary.

[westi]

The whole idea is that a viewer of an admin page gets a useful error message from WordPress and a viewer of a blog page gets a very plain db error message without any WordPress branding or linkage.

[DD32]

Basically, the point of the bland error page was to prevent general users associating a "Database Down" message with that of a WordPress message.

Eg, Digg; Everytime a poorly hosted WordPress install gets submitted, MySQL overloads itself, and WordPress cant connect, it flashes up a "WordPress database down" page, Everyones reaction? "Its another WordPress blog, of course it doesnt work, its absolutly useless", Yes; those people who say that should know better, but the simple fact is, they dont.

Its all about changing the general users view of what wordpress is, You dont want to associate negitive things like that with WordPress.

In its current form, a simple "Database Down" message which doesnt mention the hosting software, makes more sense, it gets whats wrong out there, and doesnt associate it with WordPress.

I'd nearly suggest mentioning MySQL in the error message myself..

[pishmishy]

I've created a new patch which I hope addresses mine and everyone else's concerns. I don't care much for mentioning WordPress in the error message either but I do want to provide a more helpful message to users.

[Nazgul]

The terse message should be directed at a passing visitor, not at the blog "owner".

The blog owner gets to see a more detailed message when he tries to go into the admin.

[pishmishy]

Now I've got even more questions :-) ...

If it's intended for visitors and not the user why do we even go as far as mentioning a database problem?

What about users who don't type the admin URL, and only know to follow the wp_loginout() link? I'm sure this is the case for most of my users (who admittedly are far from experts)

Why aren't we passing the terse message to wp_die()

[darkdragon]

The answer to your question is to make wp_die() themeable, so that, the custom solution is not needed.

[pishmishy]

Tidies up and documents terse error message

[pishmishy]

I'm not sure we can/should theme wp_die(), we want this function to depend on as little as possible. I've added a new proposed patch that at least tidies up the code and returns the terse message through wp_die() rather than by including HTML all over again.