Ticket #8548 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

Theme preview fails when theme in subdirectory

Reported by: zedlander Owned by:
Priority: normal Milestone: 2.7.2
Component: Themes Version: 2.7
Severity: normal Keywords:
Cc:

Description

I have a folder called dreamhost in my themes directory. All the themes display and can be activated properly, but the preview is broken, only showing a white page. This is because the preview_theme function is stripping out '/', changing 'dreamhost/classic' to 'dreamhostclassic', which then fails. Patch is attached.

Attachments

themefix.diff Download (923 bytes) - added by zedlander 3 years ago.
Diff to avoid filtering out '/' from theme filenames.

Change History

zedlander — 3 years ago

Diff to avoid filtering out '/' from theme filenames.

comment:1   DD32 — 3 years ago

  • Keywords has-patch added
  • Owner anonymous deleted
  • Version set to 2.7
  • Component changed from General to Themes

comment:2   ryan — 3 years ago

  • Milestone changed from 2.8 to 2.7.1

comment:3   ryan — 3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [10483]) Fix previewing of themes in subdirs. Props zedlander. fixes #8548

comment:4   ryan — 3 years ago

(In [10484]) Fix previewing of themes in subdirs. Props zedlander. fixes #8548 for 2.7

comment:5   chaoskaizer — 3 years ago

  • Keywords has-patch removed
  • Status changed from closed to reopened
  • Resolution fixed deleted

current fixes broke all themes that used "-" character for a directory name. example

  • themes\wp-theme
  • themes\wp-theme-27 .

comment:6   FFEMTcJ — 3 years ago

  • Milestone changed from 2.7.1 to 2.7.2

See #9244 for patch to new problem.

comment:7   automattor — 3 years ago

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [10677]) Escape hyphen in regex. Props chrisbliss18. fixes #8548 #9244 for 2.7

comment:8   ryan — 3 years ago

[10676] for trunk

Note: See TracTickets for help on using tickets.