Changeset 11098 for trunk/wp-includes/formatting.php

Timestamp:

04/27/2009 04:17:24 PM (16 years ago)

Author:

ryan

Message:

Eliminate preg_replace with /e. Props tbaboon. fixes #8689

File:

• trunk/wp-includes/formatting.php (modified) (2 diffs)

trunk/wp-includes/formatting.php

@@ -774 +774 @@
 
 /**
+ * Callback used to change %uXXXX to &#YYY; syntax
+ *
+ * @since 2.8?
+ *
+ * @param array $matches Single Match
+ * @return string An HTML entity
+ */
+function funky_javascript_callback($matches) {
+    return "&#".base_convert($matches[1],16,10).";";
+}
+
+/**
  * Fixes javascript bugs in browsers.
  *
@@ -789 +801 @@
     global $is_macIE, $is_winIE;
 
-    /** @todo use preg_replace_callback() instead */
     if ( $is_winIE || $is_macIE )
-        $text =  preg_replace("/\%u([0-9A-F]{4,4})/e",  "'&#'.base_convert('\\1',16,10).';'", $text);
+        $text =  preg_replace_callback("/\%u([0-9A-F]{4,4})/",
+                           "funky_javascript_callback",
+                           $text);
 
     return $text;