Changeset 20029 for trunk/wp-admin/includes/theme-install.php

Timestamp:

02/28/2012 09:24:44 PM (12 years ago)

Author:

nacin

Message:

Introduce WP_Theme, wp_get_themes(), and wp_get_theme() to replace get_themes(), get_theme(), get_theme_data(), current_theme_info(), and others.

• Getters and Helpers: Introduces a series of methods to allow for easy generation of headers for display, and other theme metadata, including page templates.
• Screenshots: Handles support for multiple screenshots. (see # Additional screenshots must be PNG and start with screenshot-2.png, and be sequential to be counted. see #19816.
• Error Handling: Broken themes have a WP_Error object attached to them.
• Caching: Introduces a wp_cache_themes_persistently filter (also in [20020]) to enable persistent caching of all filesystem and sanitization operations normally handled by WP_Theme (and formerly get_file_data() and get_themes()). Themes are cached individually and across five different cache keys for different data pieces.
• Compatibility: A WP_Theme object is backwards compatible with a theme's array formerly returned by get_themes() and get_theme(), and an stdClass object formerly returned by current_theme_info().
• i18n/L10n: Theme headers are now localizable with proper Text Domain and Domain Path headers, like plugins. (Language packs may remove the requirement for headers.) For page templates, see #6007 (not fixed yet, but will be easy now). For headers, fixes #15858.
• PHP and CSS files: New methods that fetch a list of theme files (for the theme editor) only on demand, rather than only loading them into memory. fixes #11214.

Functions deprecated:

• get_themes(), get_allowed_themes() and get_broken_themes() -- use wp_get_themes()
• get_theme() and current_theme_info() -- use wp_get_theme()
• get_site_allowed_themes() -- use WP_Theme::get_allowed_on_network()
• wpmu_get_blog_allowedthemes() -- use WP_theme::get_allowed_on_site()

see also [20016], [20018], [20019], [20020], [20021], [20022], [20025], [20026], [20027]. also fixes #19244.

see #20103.

File:

• trunk/wp-admin/includes/theme-install.php (modified) (1 diff)

trunk/wp-admin/includes/theme-install.php

@@ -266 +266 @@
     }
 
-    $themes = get_themes();
-    foreach ( (array) $themes as $this_theme ) {
-        if ( is_array($this_theme) && $this_theme['Stylesheet'] == $api->slug ) {
-            if ( version_compare( $this_theme['Version'], $api->version, '=' ) ) {
+    $theme = wp_get_theme( $api->slug );
+    if ( is_a( $theme, 'WP_Theme' ) ) {
+        switch ( version_compare( $theme->get('Version'), $api->version ) ) {
+            case 0; // equal
                 $type = 'latest_installed';
-            } elseif ( version_compare( $this_theme['Version'], $api->version, '>' ) ) {
+            case 1: // installed theme > api version
                 $type = 'newer_installed';
-                $newer_version = $this_theme['Version'];
-            }
-            break;
+                $newer_version = $theme->get('Version');
         }
     }