Changeset 25285 for trunk/src/wp-admin/includes/nav-menu.php

Timestamp:

09/06/2013 05:08:00 PM (13 years ago)

Author:

wonderboymusic

Message:

Use get_the_title() when dealing with post_type-like items in the admin.

Props nacin, DrewAPicture.
Fixes #14975.

File:

• trunk/src/wp-admin/includes/nav-menu.php (modified) (3 diffs)

trunk/src/wp-admin/includes/nav-menu.php

@@ -56 +56 @@
                 } elseif ( 'post_type' == $item->type ) {
                         $original_object = get_post( $item->object_id );
-                        $original_title = $original_object->post_title;
+                        $original_title = get_the_title( $original_object->ID );
                 }
 
@@ -261 +261 @@
                 $output .= '<input type="checkbox" class="menu-item-checkbox';
                 if ( property_exists( $item, 'front_or_home' ) && $item->front_or_home ) {
-                        $title = sprintf( _x( 'Home: %s', 'nav menu front page title' ), $item->post_title );
+                        $title = sprintf( _x( 'Home: %s', 'nav menu front page title' ), get_the_title( $item->ID ) );
                         $output .= ' add-to-top';
                 } elseif ( property_exists( $item, 'label' ) ) {
@@ -267 +267 @@
                 }
                 $output .= '" name="menu-item[' . $possible_object_id . '][menu-item-object-id]" value="'. esc_attr( $item->object_id ) .'" /> ';
-                $output .= isset( $title ) ? esc_html( $title ) : esc_html( $item->title );
-                $output .= '</label>';
+                if ( isset( $item->post_type ) )
+                        $output .= empty( $item->label ) ? esc_html( get_the_title( $item->ID ) ) : esc_html( $item->label );
+                else
+                        $output .= isset( $title ) ? esc_html( $title ) : esc_html( $item->title );
+                $output .= '</label>';
 
                 // Menu item hidden fields