Changeset 34599 for trunk/src/wp-includes/class-wp-comment-query.php

Timestamp:

09/26/2015 04:01:05 PM (9 years ago)

Author:

boonebgorges

Message:

Improve post field lazyloading for comments.

[34583] modified comment queries so that all post fields are no longer loaded
by default. Instead, they are loaded only when requested on individual comment
objects. This changeset improves that flow:

• WP_Comment magic methods __isset() and __get() should only load the post when a post field is being requested.
• The new update_comment_post_cache argument for WP_Comment_Query allows developers to specify that, when comments are queried, all of the posts matching those comments should be loaded into cache with a single DB hit. This parameter defaults to false, since typical comment queries are linked to a single post.

Fixes #27571.

File:

• trunk/src/wp-includes/class-wp-comment-query.php (modified) (4 diffs)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -139 +139 @@
      * @since 4.4.0 `$parent__in` and `$parent__not_in` were added.
      * @since 4.4.0 Order by `comment__in` was added. `$update_comment_meta_cache`, `$no_found_rows`,
-     *              and `$hierarchical` were added.
+     *              `$hierarchical`, and `$update_comment_post_cache` were added.
      * @access public
      *
@@ -239 +239 @@
      *     @type bool         $update_comment_meta_cache Whether to prime the metadata cache for found comments.
      *                                                   Default true.
+     *     @type bool         $update_comment_post_cache Whether to prime the cache for comment posts.
+     *                                                   Default false.
      * }
      */
@@ -282 +284 @@
             'hierarchical' => false,
             'update_comment_meta_cache' => true,
+            'update_comment_post_cache' => false,
         );
 
@@ -413 +416 @@
                 $_comments[] = $_comment;
             }
+        }
+
+        // Prime comment post caches.
+        if ( $this->query_vars['update_comment_post_cache'] ) {
+            $comment_post_ids = array();
+            foreach ( $_comments as $_comment ) {
+                $comment_post_ids[] = $_comment->comment_post_ID;
+            }
+
+            _prime_post_caches( $comment_post_ids, false, false );
         }