Make WordPress Core


Ignore:
Timestamp:
10/21/2015 04:53:51 PM (9 years ago)
Author:
boonebgorges
Message:

Prevent non-public taxonomies from registering aquery var.

[34247] made the 'public' paramater of register_taxonomy() work by blocking
requests for non-public taxonomy archives during parse_request(). Blocking
taxonomy archive requests this late means that it's impossible to register an
independent query var that matches the slug of a non-public taxonomy. By
moving the block to register_taxonomy() - not allowing these taxonomies to
register their query vars in the first place - we free up the slug for other
use. In addition, we free up a bit of processing (no need to look for the query
var in parse_request() and better parallel the way non-public post types
work. See register_post_type().

Non-public taxonomy archives that are requested using ?taxonomy=tax_name are
still blocked during parse_request. It's only custom query vars -
?tax_name=term - that are affected by this change.

Props mboynes.
Fixes #21949.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/includes/utils.php

    r34802 r35333  
    358358
    359359    foreach ( get_taxonomies( array() , 'objects' ) as $t ) {
    360         if ( ! empty( $t->query_var ) )
     360        if ( $t->public && ! empty( $t->query_var ) )
    361361            $GLOBALS['wp']->add_query_var( $t->query_var );
    362362    }
Note: See TracChangeset for help on using the changeset viewer.